Bug 398471

Summary: Review Request: lipstik - Lipstik style for KDE
Product: [Fedora] Fedora Reporter: Jakub 'Livio' Rusinek <liviopl.pl>
Component: Package ReviewAssignee: Rafał Psota <rafalzaq>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting
Target Milestone: ---Flags: rafalzaq: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-12-20 21:48:30 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Jakub 'Livio' Rusinek 2007-11-25 17:54:34 UTC
Spec URL: http://liviopl.fedorapeople.org/lipstik.spec
SRPM URL: http://liviopl.fedorapeople.org/lipstik-2.2.3-1.fc8.src.rpm
Description: Lipstik is a fast and clean style with many options 
to tune your desktop look

Comment 1 Rafał Psota 2007-11-25 17:57:18 UTC
I'll take this one.

Comment 2 Rafał Psota 2007-11-29 15:46:09 UTC
Everything seems to be ok except this:
lipstik.x86_64: W: no-documentation
Please include following files in %doc: BUGS, ChangeLog, COPYING, README, TODO.

Additional comment with explanation why .la files aren't removed would be nice.

Comment 3 Jakub 'Livio' Rusinek 2007-11-29 16:13:43 UTC
1: Ok.
2: They're needed by Lipstik configuration dialog to work properly.
   Tried with .la removed and the config dialog didn't show up because of .la
files missing. Evem core KDE libs are providing .la files [1].





 1| http://wklej.org/id/94a8ad507c

Comment 5 Rafał Psota 2007-11-30 21:00:19 UTC
I mean a comment in the spec file. Information for the next generations. ;)

There's one more thing.
lipstik.x86_64: W: file-not-utf8 /usr/share/doc/lipstik-2.2.3/ChangeLog
Simply run iconv on this file.

Comment 6 Jakub 'Livio' Rusinek 2007-12-02 12:22:14 UTC
Information for the next generations will not be given.
kdebase already provides .la without comment, so I'll also do so.

Encoding fixed. rpmlint is now quiet.

Spec URL: http://liviopl.fedorapeople.org/lipstik.spec
SRPM URL: http://liviopl.fedorapeople.org/lipstik-2.2.3-3.fc8.src.rpm

Comment 7 Rafał Psota 2007-12-02 22:54:38 UTC
Looks fine now.

APPROVED

Comment 8 Jakub 'Livio' Rusinek 2007-12-03 16:04:27 UTC
New Package CVS Request
=======================
Package Name: lipstik
Short Description: Lipstik style for KDE
Owners: liviopl
Branches: F-7 F-8
InitialCC: liviopl
Cvsextras Commits: yes

Comment 9 Kevin Fenzi 2007-12-03 19:17:41 UTC
cvs done.