Bug 398471 - Review Request: lipstik - Lipstik style for KDE
Summary: Review Request: lipstik - Lipstik style for KDE
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rafał Psota
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-11-25 17:54 UTC by Jakub 'Livio' Rusinek
Modified: 2007-12-20 21:48 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-12-20 21:48:30 UTC
Type: ---
rafalzaq: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Jakub 'Livio' Rusinek 2007-11-25 17:54:34 UTC
Spec URL: http://liviopl.fedorapeople.org/lipstik.spec
SRPM URL: http://liviopl.fedorapeople.org/lipstik-2.2.3-1.fc8.src.rpm
Description: Lipstik is a fast and clean style with many options 
to tune your desktop look

Comment 1 Rafał Psota 2007-11-25 17:57:18 UTC
I'll take this one.

Comment 2 Rafał Psota 2007-11-29 15:46:09 UTC
Everything seems to be ok except this:
lipstik.x86_64: W: no-documentation
Please include following files in %doc: BUGS, ChangeLog, COPYING, README, TODO.

Additional comment with explanation why .la files aren't removed would be nice.

Comment 3 Jakub 'Livio' Rusinek 2007-11-29 16:13:43 UTC
1: Ok.
2: They're needed by Lipstik configuration dialog to work properly.
   Tried with .la removed and the config dialog didn't show up because of .la
files missing. Evem core KDE libs are providing .la files [1].





 1| http://wklej.org/id/94a8ad507c

Comment 5 Rafał Psota 2007-11-30 21:00:19 UTC
I mean a comment in the spec file. Information for the next generations. ;)

There's one more thing.
lipstik.x86_64: W: file-not-utf8 /usr/share/doc/lipstik-2.2.3/ChangeLog
Simply run iconv on this file.

Comment 6 Jakub 'Livio' Rusinek 2007-12-02 12:22:14 UTC
Information for the next generations will not be given.
kdebase already provides .la without comment, so I'll also do so.

Encoding fixed. rpmlint is now quiet.

Spec URL: http://liviopl.fedorapeople.org/lipstik.spec
SRPM URL: http://liviopl.fedorapeople.org/lipstik-2.2.3-3.fc8.src.rpm

Comment 7 Rafał Psota 2007-12-02 22:54:38 UTC
Looks fine now.

APPROVED

Comment 8 Jakub 'Livio' Rusinek 2007-12-03 16:04:27 UTC
New Package CVS Request
=======================
Package Name: lipstik
Short Description: Lipstik style for KDE
Owners: liviopl
Branches: F-7 F-8
InitialCC: liviopl
Cvsextras Commits: yes

Comment 9 Kevin Fenzi 2007-12-03 19:17:41 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.