Spec URL: http://liviopl.fedorapeople.org/lipstik.spec SRPM URL: http://liviopl.fedorapeople.org/lipstik-2.2.3-1.fc8.src.rpm Description: Lipstik is a fast and clean style with many options to tune your desktop look
I'll take this one.
Everything seems to be ok except this: lipstik.x86_64: W: no-documentation Please include following files in %doc: BUGS, ChangeLog, COPYING, README, TODO. Additional comment with explanation why .la files aren't removed would be nice.
1: Ok. 2: They're needed by Lipstik configuration dialog to work properly. Tried with .la removed and the config dialog didn't show up because of .la files missing. Evem core KDE libs are providing .la files [1]. 1| http://wklej.org/id/94a8ad507c
Spec URL: http://liviopl.fedorapeople.org/lipstik.spec SRPM URL: http://liviopl.fedorapeople.org/lipstik-2.2.3-2.fc8.src.rpm
I mean a comment in the spec file. Information for the next generations. ;) There's one more thing. lipstik.x86_64: W: file-not-utf8 /usr/share/doc/lipstik-2.2.3/ChangeLog Simply run iconv on this file.
Information for the next generations will not be given. kdebase already provides .la without comment, so I'll also do so. Encoding fixed. rpmlint is now quiet. Spec URL: http://liviopl.fedorapeople.org/lipstik.spec SRPM URL: http://liviopl.fedorapeople.org/lipstik-2.2.3-3.fc8.src.rpm
Looks fine now. APPROVED
New Package CVS Request ======================= Package Name: lipstik Short Description: Lipstik style for KDE Owners: liviopl Branches: F-7 F-8 InitialCC: liviopl Cvsextras Commits: yes
cvs done.