Bug 401601

Summary:	Review Request: tcpflow - Network traffic recorder
Product:	[Fedora] Fedora	Reporter:	Terje Røsten <terje.rosten>
Component:	Package Review	Assignee:	Patrice Dumas <pertusus>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	pertusus: fedora-review+ jwboyer: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-12-04 19:14:04 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Terje Røsten 2007-11-27 18:32:50 UTC

Spec URL: http://terjeros.fedorapeople.org/tcpflow/tcpflow.spec
SRPM URL: http://terjeros.fedorapeople.org/tcpflow/tcpflow-0.21-1.fc.src.rpm
Description:

tcpflow is a program that captures data transmitted as part of TCP
connections (flows), and stores the data in a way that is convenient
for protocol analysis or debugging. A program like 'tcpdump' shows a
summary of packets seen on the wire, but usually doesn't store the
data that's actually being transmitted. In contrast, tcpflow
reconstructs the actual data streams and stores each flow in a
separate file for later analysis.

Comment 1 Terje Røsten 2007-11-27 18:38:48 UTC

My build script was broken, updated srpm url:

SRPM: http://terjeros.fedorapeople.org/tcpflow/tcpflow-0.21-1.fc8.src.rpm

Small note to myself: update wishlist if packages gets included:
  http://fedoraproject.org/wiki/PackageMaintainers/WishList

Comment 2 Patrice Dumas 2007-11-27 22:37:14 UTC

I don't like the additions of features that haven't been 
already accepted by upstream. In that case, upstream doesn't
seems to be updating frequently, so it may be right.

* rpmlint is silent 
* follow guidelines
* free software, license included
* match upstream
45a5aef6f043312315b7f342afc4a9c5  ./tcpflow-0.21.tar.gz
* %file section right.


APPROVED

If you care, you can keep the man page timestamp by adding 
INSTALL='install -p' or similar on the make install line.

Comment 3 Patrice Dumas 2007-11-27 22:39:02 UTC

Seems to me that license is GPL+.

Comment 4 Terje Røsten 2007-11-27 22:52:41 UTC

$ head -3 tcpflow-0.21/COPYING
                    GNU GENERAL PUBLIC LICENSE
                       Version 2, June 1991


From tpcflow-0.21/src/main.c and others

 * This source code is under the GNU Public License (GPL).  See
 * LICENSE for details.


So I guess, it's GPL+. Thanks, will fix.

Comment 5 Terje Røsten 2007-11-27 23:07:08 UTC

SPEC: http://terjeros.fedorapeople.org/tcpflow/tcpflow.spec 
SRPM: http://terjeros.fedorapeople.org/tcpflow/tcpflow-0.21-2.fc8.src.rpm

Comment 6 Terje Røsten 2007-11-27 23:11:49 UTC

> APPROVED

Thanks, that was quick!



New Package CVS Request
=======================
Package Name:  tcpflow 
Short Description:  Network traffic recorder
Owners: terjeros
Branches: F-7 F-8
InitialCC: 
Cvsextras Commits: yes

Comment 7 Terje Røsten 2007-12-04 19:14:04 UTC

Now pending for testing in F-7 and F-8.