Bug 401601 - Review Request: tcpflow - Network traffic recorder
Review Request: tcpflow - Network traffic recorder
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Patrice Dumas
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-11-27 13:32 EST by Terje Røsten
Modified: 2007-12-04 14:14 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-12-04 14:14:04 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
pertusus: fedora‑review+
jwboyer: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Terje Røsten 2007-11-27 13:32:50 EST
Spec URL: http://terjeros.fedorapeople.org/tcpflow/tcpflow.spec
SRPM URL: http://terjeros.fedorapeople.org/tcpflow/tcpflow-0.21-1.fc.src.rpm
Description:

tcpflow is a program that captures data transmitted as part of TCP
connections (flows), and stores the data in a way that is convenient
for protocol analysis or debugging. A program like 'tcpdump' shows a
summary of packets seen on the wire, but usually doesn't store the
data that's actually being transmitted. In contrast, tcpflow
reconstructs the actual data streams and stores each flow in a
separate file for later analysis.
Comment 1 Terje Røsten 2007-11-27 13:38:48 EST
My build script was broken, updated srpm url:

SRPM: http://terjeros.fedorapeople.org/tcpflow/tcpflow-0.21-1.fc8.src.rpm

Small note to myself: update wishlist if packages gets included:
  http://fedoraproject.org/wiki/PackageMaintainers/WishList

Comment 2 Patrice Dumas 2007-11-27 17:37:14 EST
I don't like the additions of features that haven't been 
already accepted by upstream. In that case, upstream doesn't
seems to be updating frequently, so it may be right.

* rpmlint is silent 
* follow guidelines
* free software, license included
* match upstream
45a5aef6f043312315b7f342afc4a9c5  ./tcpflow-0.21.tar.gz
* %file section right.


APPROVED

If you care, you can keep the man page timestamp by adding 
INSTALL='install -p' or similar on the make install line. 
Comment 3 Patrice Dumas 2007-11-27 17:39:02 EST
Seems to me that license is GPL+.
Comment 4 Terje Røsten 2007-11-27 17:52:41 EST
$ head -3 tcpflow-0.21/COPYING
                    GNU GENERAL PUBLIC LICENSE
                       Version 2, June 1991


From tpcflow-0.21/src/main.c and others

 * This source code is under the GNU Public License (GPL).  See
 * LICENSE for details.


So I guess, it's GPL+. Thanks, will fix.



Comment 6 Terje Røsten 2007-11-27 18:11:49 EST
> APPROVED

Thanks, that was quick!



New Package CVS Request
=======================
Package Name:  tcpflow 
Short Description:  Network traffic recorder
Owners: terjeros
Branches: F-7 F-8
InitialCC: 
Cvsextras Commits: yes
Comment 7 Terje Røsten 2007-12-04 14:14:04 EST
Now pending for testing in F-7 and F-8.

Note You need to log in before you can comment on or make changes to this bug.