Bug 402531

Summary: libwvstreams uses obsolete (and non-POSIX) sa_restorer
Product: [Fedora] Fedora Reporter: Oliver Falk <oliver>
Component: libwvstreamsAssignee: Ondrej Vasik <ovasik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: 8Keywords: EasyFix, Patch
Target Milestone: ---   
Target Release: ---   
Hardware: alpha   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-11-28 14:57:38 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Oliver Falk 2007-11-28 11:03:27 UTC
From my build.log:
[oliver@gosa libwvstreams]$ cat .build-4.4-1.fc8.log |tail
utils/wvcrash.cc:96: warning: ignoring return value of 'ssize_t write(int, const
void*, size_t)', declared with attribute warn_unused_result
utils/wvcrash.cc: In function 'void wvcrash_add_signal(int)':
utils/wvcrash.cc:388: error: 'struct sigaction' has no member named 'sa_restorer'
make[1]: *** [utils/wvcrash.o] Error 1
make[1]: Leaving directory `/home/oliver/cvs/F-8/libwvstreams/wvstreams-4.4'
error: Bad exit status from /var/tmp/rpm-tmp.99427 (%build)


RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.99427 (%build)


From sigaction manpage:
<snip>
  The sa_restorer element is obsolete and should not be used.  POSIX does not
specify
  a sa_restorer element.
</snip>

Comment 1 Oliver Falk 2007-11-28 14:04:58 UTC
Since it's obsolete. It's safe to remove that line - I think. Patch:
diff -up wvstreams-4.4/utils/wvcrash.cc.no_sa_restorer
wvstreams-4.4/utils/wvcrash.cc
--- wvstreams-4.4/utils/wvcrash.cc.no_sa_restorer       2007-11-28
12:03:43.000000000 +0100
+++ wvstreams-4.4/utils/wvcrash.cc      2007-11-28 12:03:53.000000000 +0100
@@ -385,7 +385,6 @@ void wvcrash_add_signal(int sig)
     act.sa_handler = wvcrash;
     sigfillset(&act.sa_mask);
     act.sa_flags = SA_ONSTACK | SA_RESTART;
-    act.sa_restorer = NULL;
     
     if (sigaction(sig, &act, NULL))
         fprintf(stderr, "Failed to setup wvcrash handler for signal %d: %s\n",

Comment 2 Ondrej Vasik 2007-11-28 14:57:38 UTC
Thanks for report and patch. Just found that ubuntu included similar patch(with
memset for act struct - which is actually better) in July and that the problem
is still not reported to upstream. I will send information to upstream. Built as
libwvstreams-4.4.1-2.fc9 , closing RAWHIDE.

Comment 3 Oliver Falk 2007-11-28 16:47:18 UTC
Can you please include in f8 as well!?

Comment 4 Ondrej Vasik 2007-11-29 09:15:02 UTC
No problem, will do update to 4.4.1 today with this patch included...

Comment 5 Fedora Update System 2007-12-03 11:48:42 UTC
libwvstreams-4.4.1-1.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.