Red Hat Bugzilla – Bug 402531
libwvstreams uses obsolete (and non-POSIX) sa_restorer
Last modified: 2007-12-03 06:48:42 EST
From my build.log:
[oliver@gosa libwvstreams]$ cat .build-4.4-1.fc8.log |tail
utils/wvcrash.cc:96: warning: ignoring return value of 'ssize_t write(int, const
void*, size_t)', declared with attribute warn_unused_result
utils/wvcrash.cc: In function 'void wvcrash_add_signal(int)':
utils/wvcrash.cc:388: error: 'struct sigaction' has no member named 'sa_restorer'
make: *** [utils/wvcrash.o] Error 1
make: Leaving directory `/home/oliver/cvs/F-8/libwvstreams/wvstreams-4.4'
error: Bad exit status from /var/tmp/rpm-tmp.99427 (%build)
RPM build errors:
Bad exit status from /var/tmp/rpm-tmp.99427 (%build)
From sigaction manpage:
The sa_restorer element is obsolete and should not be used. POSIX does not
a sa_restorer element.
Since it's obsolete. It's safe to remove that line - I think. Patch:
diff -up wvstreams-4.4/utils/wvcrash.cc.no_sa_restorer
--- wvstreams-4.4/utils/wvcrash.cc.no_sa_restorer 2007-11-28
+++ wvstreams-4.4/utils/wvcrash.cc 2007-11-28 12:03:53.000000000 +0100
@@ -385,7 +385,6 @@ void wvcrash_add_signal(int sig)
act.sa_handler = wvcrash;
act.sa_flags = SA_ONSTACK | SA_RESTART;
- act.sa_restorer = NULL;
if (sigaction(sig, &act, NULL))
fprintf(stderr, "Failed to setup wvcrash handler for signal %d: %s\n",
Thanks for report and patch. Just found that ubuntu included similar patch(with
memset for act struct - which is actually better) in July and that the problem
is still not reported to upstream. I will send information to upstream. Built as
libwvstreams-4.4.1-2.fc9 , closing RAWHIDE.
Can you please include in f8 as well!?
No problem, will do update to 4.4.1 today with this patch included...
libwvstreams-4.4.1-1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.