Bug 404721

Summary:	segfault when trying to open a non existing device
Product:	[Fedora] Fedora	Reporter:	Milan Broz <mbroz>
Component:	cryptsetup-luks	Assignee:	Till Maas <opensource>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	low
Version:	rawhide	CC:	agk, dwysocha, mbroz, opensource, pjones, prockai, pvrabec
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	1.0.6-0.1.pre2.fc9	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-03-03 22:07:25 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Milan Broz 2007-11-29 17:16:20 UTC

Cryptsetup segfaults if called for non-existent device

# cryptsetup luksOpen /dev/bla test
Segmentation fault

cryptsetup-luks-1.0.5-7

Simple patch already in devel svn, or here
http://article.gmane.org/gmane.linux.kernel.device-mapper.dm-crypt/2218

Comment 1 Till Maas 2008-01-11 19:44:18 UTC

Thanks for reporting this. This happens also in F8, but it does not in F7. I do
not really know why. Nevetheless, I guess it would be enough to fix this in
rawhide. I plan to maybe upgrade rawhide to cryptsetup 1.0.6 pre, afaik it
mainly contains useful patches from debian, but I try it first on my notebook.
Then this would be fixed, too.

Comment 2 Milan Broz 2008-01-21 16:19:42 UTC

Till, there are other serious cryptsetup problems in rawhide (my test scripts
sometimes left temporary dm-crypt mapping etc.)
(Another debian patch "run udevsettle after dm device creation").

These patches should be backported asap or we should switch to 1.0.6 pre.

(Please let me know if you need help with testing or fixing these bugs.)

(btw bug is apparently even in F7 but because some compiler optimization it
works :-)

Comment 3 Till Maas 2008-01-21 17:12:38 UTC

(In reply to comment #2)
> Till, there are other serious cryptsetup problems in rawhide (my test scripts
> sometimes left temporary dm-crypt mapping etc.)

Could I have access to your test scripts?

> These patches should be backported asap or we should switch to 1.0.6 pre.
> 
> (Please let me know if you need help with testing or fixing these bugs.)

It would be great when you could test cryptsetup 1.0.6 pre1, e.g. these rpms:
http://koji.fedoraproject.org/koji/taskinfo?taskID=362539

Comment 4 Till Maas 2008-01-21 22:34:52 UTC

There is a bug in debian:
http://bugs.debian.org/460409

Cryptsetup 1.0.6 pre1 does not support adding keys to an opened luks partition
anymore.

Comment 5 Till Maas 2008-03-03 22:07:25 UTC

Rawhide does now contain cryptsetup 1.0.6 pre2. Nevertheless I am still
interested in the test scripts. :-)