Bug 405161
| Summary: | Review Request: xvkbd - X virtual Keyboard | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kevin DeKorte <kdekorte> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, kevin, mtasaka, notting |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-01-14 10:56:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Kevin DeKorte
2007-11-29 21:46:34 UTC
Need Sponsor Adding the FE-NEEDSPONSOR blocker here so sponsors can find your request easier. You may want to take a look at: http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored Do you have other packages to submit at this time? Or can you go do some 'pre-reviews' of other pending submissions to show you know the guidelines? Well, for general packaging guidelines you can refer to http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines * Please consider to use %{?dist} tag. http://fedoraproject.org/wiki/Packaging/DistTag Some random comments: * The license tag "GPL" is not valid for Fedora. Please refer to http://fedoraproject.org/wiki/Licensing http://fedoraproject.org/wiki/Packaging/LicensingGuidelines * "Requires: Xaw3d libXaw libXtst" are usually not needed as rpmbuild checks the dependencies for libraries and adds them as Requires, which should automatically pull those rpms. * Your srpm does not build. http://koji.fedoraproject.org/koji/taskinfo?taskID=298953 At least imake is missing from BuildRequires. * setup is not quiet (You can check your srpm beforehand by using rpmlint [in rpmlint rpm] as $ rpmlint *rpm ) * Please check if your build honors Fedora specific compilation flags (please check the section "Compiler flags" of "Guidelines" wiki) * %{_datadir}/X11/app-defaults is already owned by libXt and this package should not own this directory. ! Note When you write ----------------------------------------------------------- %files %{_datadir}/X11/app-defaults ----------------------------------------------------------- This includes the directory %_datadir/X11/app-defaults itself and all files/directories/etc under %_datadir/X11/app-defaults. * And perhaps installing files under %_libdir/X11/app-defaults is not desired. * Files under %_mandir are automatically tagged as %doc. * Also please fix %changelog. ! Note: Please change the release number of your spec/srpm each time when you modify them. ping? ping again? I will close this bug if no response from the reporter is received by 2008-01-25. Close it... Okay. Once closing. Thank you anyway! |