Bug 405161

Summary: Review Request: xvkbd - X virtual Keyboard
Product: [Fedora] Fedora Reporter: Kevin DeKorte <kdekorte>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: fedora-package-review, kevin, mtasaka, notting
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-01-14 05:56:35 EST Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 201449    

Description Kevin DeKorte 2007-11-29 16:46:34 EST
Spec URL: http://dekorte.homeip.net/yum/fedora/SPECS/xvkbd.spec
SRPM URL: http://dekorte.homeip.net/yum/fedora/SRPMS/xvkbd-2.8-1.src.rpm
Description: Virtual Keyboard for X
Comment 1 Kevin DeKorte 2007-11-29 17:11:39 EST
Need Sponsor
Comment 2 Kevin Fenzi 2007-12-02 13:25:37 EST
Adding the FE-NEEDSPONSOR blocker here so sponsors can find your request easier. 

You may want to take a look at: 
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Do you have other packages to submit at this time? Or can you go do some
'pre-reviews' of other pending submissions to show you know the guidelines?
Comment 3 Mamoru TASAKA 2007-12-18 12:33:14 EST
Well, for general packaging guidelines you can refer to
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

* Please consider to use %{?dist} tag.
  http://fedoraproject.org/wiki/Packaging/DistTag

Some random comments:

* The license tag "GPL" is not valid for Fedora. Please refer to
  http://fedoraproject.org/wiki/Licensing
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines

* "Requires: Xaw3d libXaw libXtst" are usually not needed
  as rpmbuild checks the dependencies for libraries and adds
  them as Requires, which should automatically pull those rpms.

* Your srpm does not build.
  http://koji.fedoraproject.org/koji/taskinfo?taskID=298953
  At least imake is missing from BuildRequires.

* setup is not quiet (You can check your srpm beforehand by
  using rpmlint [in rpmlint rpm] as $ rpmlint *rpm )

* Please check if your build honors Fedora specific compilation
  flags (please check the section "Compiler flags" of
  "Guidelines" wiki)

* %{_datadir}/X11/app-defaults is already owned by libXt and this
   package should not own this directory.
  ! Note
    When you write
-----------------------------------------------------------
%files
%{_datadir}/X11/app-defaults
-----------------------------------------------------------
    This includes the directory %_datadir/X11/app-defaults itself
    and all files/directories/etc under %_datadir/X11/app-defaults.

* And perhaps installing files under %_libdir/X11/app-defaults is
  not desired.

* Files under %_mandir are automatically tagged as %doc.

* Also please fix %changelog.

! Note:
  Please change the release number of your spec/srpm each time
  when you modify them.
Comment 4 Mamoru TASAKA 2007-12-24 09:31:44 EST
ping?
Comment 5 Mamoru TASAKA 2008-01-11 10:24:04 EST
ping again?
Comment 6 Mamoru TASAKA 2008-01-13 11:43:33 EST
I will close this bug if no response from the reporter is received by
2008-01-25.
Comment 7 Kevin DeKorte 2008-01-13 13:56:44 EST
Close it...  
Comment 8 Mamoru TASAKA 2008-01-14 05:56:35 EST
Okay. Once closing. Thank you anyway!