Spec URL: http://dekorte.homeip.net/yum/fedora/SPECS/xvkbd.spec SRPM URL: http://dekorte.homeip.net/yum/fedora/SRPMS/xvkbd-2.8-1.src.rpm Description: Virtual Keyboard for X
Need Sponsor
Adding the FE-NEEDSPONSOR blocker here so sponsors can find your request easier. You may want to take a look at: http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored Do you have other packages to submit at this time? Or can you go do some 'pre-reviews' of other pending submissions to show you know the guidelines?
Well, for general packaging guidelines you can refer to http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines * Please consider to use %{?dist} tag. http://fedoraproject.org/wiki/Packaging/DistTag Some random comments: * The license tag "GPL" is not valid for Fedora. Please refer to http://fedoraproject.org/wiki/Licensing http://fedoraproject.org/wiki/Packaging/LicensingGuidelines * "Requires: Xaw3d libXaw libXtst" are usually not needed as rpmbuild checks the dependencies for libraries and adds them as Requires, which should automatically pull those rpms. * Your srpm does not build. http://koji.fedoraproject.org/koji/taskinfo?taskID=298953 At least imake is missing from BuildRequires. * setup is not quiet (You can check your srpm beforehand by using rpmlint [in rpmlint rpm] as $ rpmlint *rpm ) * Please check if your build honors Fedora specific compilation flags (please check the section "Compiler flags" of "Guidelines" wiki) * %{_datadir}/X11/app-defaults is already owned by libXt and this package should not own this directory. ! Note When you write ----------------------------------------------------------- %files %{_datadir}/X11/app-defaults ----------------------------------------------------------- This includes the directory %_datadir/X11/app-defaults itself and all files/directories/etc under %_datadir/X11/app-defaults. * And perhaps installing files under %_libdir/X11/app-defaults is not desired. * Files under %_mandir are automatically tagged as %doc. * Also please fix %changelog. ! Note: Please change the release number of your spec/srpm each time when you modify them.
ping?
ping again?
I will close this bug if no response from the reporter is received by 2008-01-25.
Close it...
Okay. Once closing. Thank you anyway!