Bug 407041
Summary: | Review Request: pcapdiff - Compares packet captures, detects forged, dropped or mangled packets | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Gwyn Ciesla <gwync> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | low | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | fedora-package-review, notting, panemade |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-12-28 23:57:27 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 407031 | ||
Bug Blocks: |
Description
Gwyn Ciesla
2007-12-01 00:05:43 UTC
Unable to download SRPM Better URLs seem to be: http://zanoni.jcomserv.net/fedora/pcapdiff/pcapdiff.spec http://zanoni.jcomserv.net/fedora/pcapdiff/pcapdiff-0.1-1.fc8.src.rpm Sorry, copy/paste error. :) Corrected BR issue: http://zanoni.jcomserv.net/fedora/pcapdiff/pcapdiff.spec http://zanoni.jcomserv.net/fedora/pcapdiff/pcapdiff-0.1-2.fc8.src.rpm Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 2f7f122969c7894a6aff3e72c886f63d pcapdiff-0.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available. + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI App. APPROVED. Many thanks! New Package CVS Request ======================= Package Name: pcapdiff Short Description: Compares packet captures, detects forged, dropped or mangled packets Owners: limb Branches: F-7 F-8 EL-4 EL-5 InitialCC: Cvsextras Commits: yes cvs done. Is this built for all requested branches? Fedora yes, EPEL, building now. Imported and built some time ago. . . Setting Correct Resolution for this review |