Bug 407041

Summary:	Review Request: pcapdiff - Compares packet captures, detects forged, dropped or mangled packets
Product:	[Fedora] Fedora	Reporter:	Gwyn Ciesla <gwync>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, notting, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-12-28 23:57:27 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	407031
Bug Blocks:

Description Gwyn Ciesla 2007-12-01 00:05:43 UTC

SPEC URL : http://zanoni/fedora/pcapdiff/pcapdiff.spec
SRPM URL : http://zanoni/fedora/pcapdiff/pcapdiff-0.1-1.fc8.src.rpm
Decription: Pcapdiff is a tool developed by the EFF to compare two packet
captures and
identify potentially forged, dropped, or mangled packets. Two technically-
inclined friends can set up packet captures (e.g. tcpdump or Wireshark) on
their own computers and produce network traffic between their two computers 
over the Internet. Later, they can run pcapdiff on the two packet capture 
files to identify suspicious packets for further investigation. See 
Detecting packet injection: a guide to observing packet spoofing by ISPs 
and EFF's Test Your ISP Project for more background.

Comment 1 Parag AN(पराग) 2007-12-01 02:49:10 UTC

Unable to download SRPM

Comment 2 Jason Tibbitts 2007-12-02 03:28:38 UTC

Better URLs seem to be:

http://zanoni.jcomserv.net/fedora/pcapdiff/pcapdiff.spec
http://zanoni.jcomserv.net/fedora/pcapdiff/pcapdiff-0.1-1.fc8.src.rpm

Comment 3 Gwyn Ciesla 2007-12-02 23:40:17 UTC

Sorry, copy/paste error. :)

Comment 4 Gwyn Ciesla 2007-12-04 13:41:50 UTC

Corrected BR issue:
http://zanoni.jcomserv.net/fedora/pcapdiff/pcapdiff.spec
http://zanoni.jcomserv.net/fedora/pcapdiff/pcapdiff-0.1-2.fc8.src.rpm

Comment 5 Parag AN(पराग) 2007-12-07 08:43:28 UTC

Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
2f7f122969c7894a6aff3e72c886f63d  pcapdiff-0.1.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI App.
APPROVED.

Comment 6 Gwyn Ciesla 2007-12-07 12:50:11 UTC

Many thanks!

New Package CVS Request
=======================
Package Name: pcapdiff
Short Description: Compares packet captures, detects forged, dropped or mangled
packets
Owners: limb 
Branches: F-7 F-8 EL-4 EL-5
InitialCC: 
Cvsextras Commits: yes

Comment 7 Kevin Fenzi 2007-12-07 17:01:07 UTC

cvs done.

Comment 8 Parag AN(पराग) 2007-12-15 09:36:06 UTC

Is this built for all requested branches?

Comment 9 Gwyn Ciesla 2007-12-15 17:16:32 UTC

Fedora yes, EPEL, building now.

Comment 10 Gwyn Ciesla 2007-12-28 23:57:27 UTC

Imported and built some time ago. . .

Comment 11 Parag AN(पराग) 2008-01-16 15:18:38 UTC

Setting Correct Resolution for this review