Bug 409291

Summary:	Review Request: libopensync-plugin-sunbird - Mozilla Calendar / Sunbird Synchronization Plug-In for OpenSync
Product:	[Fedora] Fedora	Reporter:	Marek Mahut <mmahut>
Component:	Package Review	Assignee:	Michal Fabry <mfabry>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	andreas.bierfert, fedora-package-review, notting
Target Milestone:	---	Flags:	mfabry: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-12-06 22:19:13 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Marek Mahut 2007-12-03 20:23:21 UTC

Spec URL: http://mmahut.fedorapeople.org/reviews/libopensync-plugin-sunbird/libopensync-plugin-sunbird.spec
SRPM URL: http://mmahut.fedorapeople.org/reviews/libopensync-plugin-sunbird/libopensync-plugin-sunbird-0.22-1.fc8.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=269478
Description: This plug-in allows applications using OpenSync to synchronize to and
from Mozilla Calendar / Sunbird.

Comment 1 Michal Fabry 2007-12-03 21:06:23 UTC

I think, 'make' should be 'make %{?_smp_mflags}'. Everything else seems to be
ok. RPMLint is silent. Build in mock is ok.

Comment 2 Andreas Bierfert 2007-12-03 21:44:09 UTC

The .la file should not be included imho but anyway from a quick look it seems fine.

Comment 3 Marek Mahut 2007-12-03 21:46:58 UTC

Andreas, should I remove this file from package using rm duing %build?

Comment 4 Andreas Bierfert 2007-12-03 21:59:45 UTC

Yes. Just do something like rm
$RPM_BUILD_ROOT/%{_libdir}/opensync/plugins/sunbird_sync.la

:)

Comment 5 Marek Mahut 2007-12-03 22:08:56 UTC

Spec file and src rpm updated.

 
http://mmahut.fedorapeople.org/reviews/libopensync-plugin-sunbird/libopensync-plugin-sunbird-0.22-2.fc8.src.rpm


Andreas, do you mind if I put your as co-maintainer of this package?

Comment 6 Michal Fabry 2007-12-03 22:17:06 UTC

APPROVED

Comment 7 Andreas Bierfert 2007-12-04 07:40:12 UTC

Sure go ahead.

Comment 8 Marek Mahut 2007-12-04 07:56:48 UTC

Thank you Michal for review. Thank you Andreas for valuable help.

New Package CVS Request
=======================
Package Name: libopensync-plugin-sunbird
Short Description: Mozilla Calendar / Sunbird Synchronization Plug-In for OpenSync
Owners: mmahut, jwb
Branches: F-7 F-8
Cvsextras Commits: yes

Comment 9 Lubomir Kundrak 2007-12-04 08:26:28 UTC

(In reply to comment #4)
> Yes. Just do something like rm
> $RPM_BUILD_ROOT/%{_libdir}/opensync/plugins/sunbird_sync.la

Andreas: Some people consider %exclude in %files more elegant.

Comment 10 Andreas Bierfert 2007-12-04 11:52:21 UTC

I do myself but afaik %exclude should not be used because rpm then calculates a
wrong package size (which does not really harm anyone but makes rpm suggest a
wrong size of the package).

Comment 11 Kevin Fenzi 2007-12-04 20:08:13 UTC

cvs done.

Comment 12 John Berninger 2007-12-04 20:55:33 UTC

I thnk 'jwb' as co-owner in comment 8's VS request was incorrect...  Andreas
isn't 'jwb', since I'm 'jwb'.  Andreas, care to add a CVS request with the
correct id?

Package CVS Request
=======================
Package Name: libopensync-plugin-sunbird
Owners: mmahut      (removing jwb)

Comment 13 Marek Mahut 2007-12-05 06:24:19 UTC

Oooooooooops.

Owners: mmahut, awjb

Sorry!

Comment 14 Kevin Fenzi 2007-12-05 19:31:02 UTC

ok. I think it should be all fixed up. 
Let me know if you need any further changes.

Comment 15 Marek Mahut 2007-12-06 22:19:13 UTC

Thank you all!