Bug 409291
Summary: | Review Request: libopensync-plugin-sunbird - Mozilla Calendar / Sunbird Synchronization Plug-In for OpenSync | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Marek Mahut <mmahut> |
Component: | Package Review | Assignee: | Michal Fabry <mfabry> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | andreas.bierfert, fedora-package-review, notting |
Target Milestone: | --- | Flags: | mfabry:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-12-06 22:19:13 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Marek Mahut
2007-12-03 20:23:21 UTC
I think, 'make' should be 'make %{?_smp_mflags}'. Everything else seems to be ok. RPMLint is silent. Build in mock is ok. The .la file should not be included imho but anyway from a quick look it seems fine. Andreas, should I remove this file from package using rm duing %build? Yes. Just do something like rm $RPM_BUILD_ROOT/%{_libdir}/opensync/plugins/sunbird_sync.la :) Spec file and src rpm updated. http://mmahut.fedorapeople.org/reviews/libopensync-plugin-sunbird/libopensync-plugin-sunbird-0.22-2.fc8.src.rpm Andreas, do you mind if I put your as co-maintainer of this package? APPROVED Sure go ahead. Thank you Michal for review. Thank you Andreas for valuable help. New Package CVS Request ======================= Package Name: libopensync-plugin-sunbird Short Description: Mozilla Calendar / Sunbird Synchronization Plug-In for OpenSync Owners: mmahut, jwb Branches: F-7 F-8 Cvsextras Commits: yes (In reply to comment #4) > Yes. Just do something like rm > $RPM_BUILD_ROOT/%{_libdir}/opensync/plugins/sunbird_sync.la Andreas: Some people consider %exclude in %files more elegant. I do myself but afaik %exclude should not be used because rpm then calculates a wrong package size (which does not really harm anyone but makes rpm suggest a wrong size of the package). cvs done. I thnk 'jwb' as co-owner in comment 8's VS request was incorrect... Andreas isn't 'jwb', since I'm 'jwb'. Andreas, care to add a CVS request with the correct id? Package CVS Request ======================= Package Name: libopensync-plugin-sunbird Owners: mmahut (removing jwb) Oooooooooops. Owners: mmahut, awjb Sorry! ok. I think it should be all fixed up. Let me know if you need any further changes. Thank you all! |