Bug 409291 - Review Request: libopensync-plugin-sunbird - Mozilla Calendar / Sunbird Synchronization Plug-In for OpenSync
Summary: Review Request: libopensync-plugin-sunbird - Mozilla Calendar / Sunbird Synch...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michal Fabry
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-12-03 20:23 UTC by Marek Mahut
Modified: 2007-12-06 22:19 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-12-06 22:19:13 UTC
Type: ---
mfabry: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Comment 1 Michal Fabry 2007-12-03 21:06:23 UTC
I think, 'make' should be 'make %{?_smp_mflags}'. Everything else seems to be
ok. RPMLint is silent. Build in mock is ok.

Comment 2 Andreas Bierfert 2007-12-03 21:44:09 UTC
The .la file should not be included imho but anyway from a quick look it seems fine.

Comment 3 Marek Mahut 2007-12-03 21:46:58 UTC
Andreas, should I remove this file from package using rm duing %build?

Comment 4 Andreas Bierfert 2007-12-03 21:59:45 UTC
Yes. Just do something like rm
$RPM_BUILD_ROOT/%{_libdir}/opensync/plugins/sunbird_sync.la

:)

Comment 5 Marek Mahut 2007-12-03 22:08:56 UTC
Spec file and src rpm updated.

 
http://mmahut.fedorapeople.org/reviews/libopensync-plugin-sunbird/libopensync-plugin-sunbird-0.22-2.fc8.src.rpm


Andreas, do you mind if I put your as co-maintainer of this package?

Comment 6 Michal Fabry 2007-12-03 22:17:06 UTC
APPROVED

Comment 7 Andreas Bierfert 2007-12-04 07:40:12 UTC
Sure go ahead.

Comment 8 Marek Mahut 2007-12-04 07:56:48 UTC
Thank you Michal for review. Thank you Andreas for valuable help.

New Package CVS Request
=======================
Package Name: libopensync-plugin-sunbird
Short Description: Mozilla Calendar / Sunbird Synchronization Plug-In for OpenSync
Owners: mmahut, jwb
Branches: F-7 F-8
Cvsextras Commits: yes


Comment 9 Lubomir Kundrak 2007-12-04 08:26:28 UTC
(In reply to comment #4)
> Yes. Just do something like rm
> $RPM_BUILD_ROOT/%{_libdir}/opensync/plugins/sunbird_sync.la

Andreas: Some people consider %exclude in %files more elegant.

Comment 10 Andreas Bierfert 2007-12-04 11:52:21 UTC
I do myself but afaik %exclude should not be used because rpm then calculates a
wrong package size (which does not really harm anyone but makes rpm suggest a
wrong size of the package).

Comment 11 Kevin Fenzi 2007-12-04 20:08:13 UTC
cvs done.

Comment 12 John Berninger 2007-12-04 20:55:33 UTC
I thnk 'jwb' as co-owner in comment 8's VS request was incorrect...  Andreas
isn't 'jwb', since I'm 'jwb'.  Andreas, care to add a CVS request with the
correct id?

Package CVS Request
=======================
Package Name: libopensync-plugin-sunbird
Owners: mmahut      (removing jwb)


Comment 13 Marek Mahut 2007-12-05 06:24:19 UTC
Oooooooooops.

Owners: mmahut, awjb

Sorry!

Comment 14 Kevin Fenzi 2007-12-05 19:31:02 UTC
ok. I think it should be all fixed up. 
Let me know if you need any further changes. 

Comment 15 Marek Mahut 2007-12-06 22:19:13 UTC
Thank you all!


Note You need to log in before you can comment on or make changes to this bug.