Bug 411491 (perl-MRO-Compat)

This is a DBIx::Class prereq.

make test gave me
t/01use.............ok
t/02pod.............skipped
        all skipped: Test::Pod 1.14 required for testing POD
t/03pod_coverage....skipped
        all skipped: Test::Pod::Coverage 1.04 required for testing POD coverage
t/10basic...........ok
t/15pkg_gen.........ok
t/20mros............ok
All tests successful, 2 tests skipped.

AND
rpmlint gave
perl-MRO-Compat.src:47: W: rpm-buildroot-usage %build rm -rf %{buildroot}
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

perl-MRO-Compat.src:49: W: rpm-buildroot-usage %build make pure_install
PERL_INSTALL_ROOT=%{buildroot}
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

perl-MRO-Compat.src:51: W: rpm-buildroot-usage %build find %{buildroot} -type f
-name .packlist -exec rm -f {} +
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

perl-MRO-Compat.src:52: W: rpm-buildroot-usage %build find %{buildroot} -depth
-type d -exec rmdir {} 2>/dev/null \;
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

perl-MRO-Compat.src:54: W: rpm-buildroot-usage %build %{_fixperms} %{buildroot}/*
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

perl-MRO-Compat.src: E: no-cleaning-of-buildroot %install
You should clean $RPM_BUILD_ROOT in the %clean section and just after the
beginning of %install section. Use "rm -Rf $RPM_BUILD_ROOT".

perl-MRO-Compat.src: W: no-%install-section
The spec file does not contain an %install section.  Even if some packages
don't directly need it, section markers may be overridden in rpm's
configuration to provide additional "under the hood" functionality.  Add the
section, even if empty.

Updated to add br's on Test::Pod, ::Coverage.

The rpmlint complaints have been resolved; %INstall != %install apparently, even
if rpmbuild thinks so :)

SRPM URL:
http://fedora.biggerontheinside.net/review/perl-MRO-Compat-0.05-3.fc8.src.rpm
SPEC URL: http://fedora.biggerontheinside.net/review/perl-MRO-Compat.spec

with new updated package I saw
perl-MRO-Compat.src:50: W: rpm-buildroot-usage %build rm -rf %{buildroot}
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

perl-MRO-Compat.src:52: W: rpm-buildroot-usage %build make pure_install
PERL_INSTALL_ROOT=%{buildroot}
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

perl-MRO-Compat.src:54: W: rpm-buildroot-usage %build find %{buildroot} -type f
-name .packlist -exec rm -f {} +
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

perl-MRO-Compat.src:55: W: rpm-buildroot-usage %build find %{buildroot} -depth
-type d -exec rmdir {} 2>/dev/null \;
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

perl-MRO-Compat.src:57: W: rpm-buildroot-usage %build %{_fixperms} %{buildroot}/*
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

perl-MRO-Compat.src: E: no-cleaning-of-buildroot %install
You should clean $RPM_BUILD_ROOT in the %clean section and just after the
beginning of %install section. Use "rm -Rf $RPM_BUILD_ROOT".

perl-MRO-Compat.src: W: no-%install-section
The spec file does not contain an %install section.  Even if some packages
don't directly need it, section markers may be overridden in rpm's
configuration to provide additional "under the hood" functionality.  Add the
section, even if empty.

SRPM URL:
http://fedora.biggerontheinside.net/review/perl-MRO-Compat-0.05-4.fc8.src.rpm
SPEC URL: http://fedora.biggerontheinside.net/review/perl-MRO-Compat.spec

Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
43ef6e27ad3a0c0e119a2a515110b464  MRO-Compat-0.05.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'inc', 'blib/lib', 'blib/arch')" t/01use.t t/02pod.t t/03pod_coverage.t
t/10basic.t t/15pkg_gen.t t/20mros.t
t/01use.............ok
t/02pod.............ok
t/03pod_coverage....ok
t/10basic...........ok
t/15pkg_gen.........ok
t/20mros............ok
All tests successful.
Files=6, Tests=26,  1 wallclock secs ( 0.31 cusr +  0.06 csys =  0.37 CPU)
+ Package perl-MRO-Compat-0.05-4.fc9 ->
  Provides: perl(MRO::Compat) = 0.05
  Requires: perl >= 0:5.006_000 perl(:MODULE_COMPAT_5.8.8) perl(Class::C3) >=
0.19 perl(strict) perl(warnings)
APPROVED.

New Package CVS Request
=======================
Package Name: perl-MRO-Compat
Short Description: Mro::* interface compatibility for Perls < 5.9.5
Owners: cweyl
Branches: F-7, F-8, devel
InitialCC: perl-sig

cvs done.

Imported and building.  Thanks for the review! :)