SRPM URL: http://fedora.biggerontheinside.net/review/perl-Class-Accessor-Grouped-0.07000-1.fc7.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-Class-Accessor-Grouped.spec Description: This class lets you build groups of accessors that will call different getters and setters.
This is a DBIx::Class prereq.
rpmlint gave me perl-Class-Accessor-Grouped.noarch: E: zero-length /usr/share/doc/perl-Class-Accessor-Grouped-0.07000/t/lib/NotReallyAClass.pm I think you should remove it.
(In reply to comment #2) > rpmlint gave me > perl-Class-Accessor-Grouped.noarch: E: zero-length > /usr/share/doc/perl-Class-Accessor-Grouped-0.07000/t/lib/NotReallyAClass.pm > > I think you should remove it. This is part of the test suqite, included in %doc as docs, and is expected.
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM But NOT for RPM. ==>see comment#3 + source files match upstream url e38f47b4732df2e3af1cdcea035f9b2b Class-Accessor-Grouped-0.07000.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/*.t t/*/*.t t/accessors........ok t/accessors_ro.....ok t/accessors_wo.....ok t/basic............ok t/component........ok t/inherited........ok t/manifest.........skipped all skipped: set TEST_AUTHOR to enable this test t/pod_coverage.....skipped all skipped: set TEST_AUTHOR to enable this test t/pod_spelling.....skipped all skipped: set TEST_AUTHOR to enable this test t/pod_syntax.......skipped all skipped: set TEST_AUTHOR to enable this test t/strict...........skipped all skipped: set TEST_AUTHOR to enable this test t/style_no_tabs....skipped all skipped: set TEST_AUTHOR to enable this test t/warnings.........skipped all skipped: set TEST_AUTHOR to enable this test All tests successful, 7 tests skipped. Files=13, Tests=188, 1 wallclock secs ( 0.60 cusr + 0.16 csys = 0.76 CPU) + Package perl-Class-Accessor-Grouped-0.07000-1.fc9 -> Provides: perl(Class::Accessor::Grouped) = 0.07000 Requires: perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Class::Inspector) perl(MRO::Compat) perl(Scalar::Util) perl(strict) perl(vars) perl(warnings) APPROVED.
New Package CVS Request ======================= Package Name: perl-Class-C3-Componentised Short Description: Load mix-ins or components to your C3-based class Owners: cweyl Branches: F-7, F-8, devel InitialCC: perl-sig
Do you mean the package name to be perl-Class-Accessor-Grouped here? Can you provide an updated name and description and reset the flag?
And this is why I alias my bugs.... sigh
New Package CVS Request ======================= Package Name: perl-Class-Accessor-Grouped Short Description: Lets you build groups of accessors Owners: cweyl Branches: F-7, F-8, devel InitialCC: perl-sig
cvs done.
Imported and built; thanks for the review!
Package Change Request ====================== Package Name: perl-Class-Accessor-Grouped New Branches: el6 Owners: iarnell tremble
Git done (by process-git-requests).