Bug 411531
| Summary: | Review Request: perl-Class-C3-Componentised - Load mix-ins or components to your C3-based class | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, iarnell, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/Class-C3-Componentised/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-12-06 22:58:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 411551 | ||
|
Description
Chris Weyl
2007-12-05 04:47:03 UTC
perl-Class-C3-Componentised.noarch: W: doc-file-dependency /usr/share/doc/perl-Class-C3-Componentised-1.0001/t/lib/MyModule.pm perl(base) An included file marked as %doc creates a possible additional dependency in the package. Usually, this is not wanted and may be caused by eg. example scripts with executable bits set included in the package's documentation. SRPM URL: http://fedora.biggerontheinside.net/review/perl-Class-C3-Componentised-1.0001-3.fc8.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-Class-C3-Componentised.spec Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 0e006802cff4acc319d00f4082239f9d Class-C3-Componentised-1.0001.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/*.t t/00-load.........# Testing Class::C3::Componentised 1.0001, Perl 5.008008, /usr/bin/perl ok t/01-basic........ok t/pod-coverage....ok t/pod.............ok All tests successful. Files=4, Tests=6, 0 wallclock secs ( 0.25 cusr + 0.06 csys = 0.31 CPU) + Package perl-Class-C3-Componentised-1.0001-3.fc9 -> Provides: perl(Class::C3::Componentised) = 1.0001 Requires: perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Class::C3) perl(Class::Inspector) perl(base) perl(strict) perl(warnings) APPROVED. New Package CVS Request ======================= Package Name: perl-Class-C3-Componentised Short Description: Load mix-ins or components to your C3-based class Owners: cweyl Branches: F-7, F-8, devel InitialCC: perl-sig cvs done. Imported and building. Thanks for the review! :) Package Change Request ====================== Package Name: perl-Class-C3-Componentised New Branches: el6 Owners: iarnell tremble Git done (by process-git-requests). |