Bug 41490

Summary: builtin ripper blocks on device open after first mp3 encode completes
Product: [Retired] Red Hat Powertools Reporter: j. alan eldridge <alane>
Component: gripAssignee: Tim Powers <timp>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 7.1   
Target Milestone: ---   
Target Release: ---   
Hardware: i386   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2001-05-21 06:16:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
patch to close fds before exec
none
write debug out to stderr, unbuffer stdout so debugging is useful
none
updated spec file including my patches
none
a source RPM for 2.95 with my patches + the makefile patch none

Description j. alan eldridge 2001-05-21 06:11:56 UTC 
Description of Problem:

The built-in ripper (cdparanoia library) blocks on device open after the 
first mp3 encode completes. This is because the file descriptor for the 
device is being inherited by the (2nd and later) child (encoder) process 
which is forked off while a rip is going on. Patch is to close all fds > 
2 (stderr) after fork but before exec (in my patch, this is done in 
RedirectIO() in grip.c).

Additional information:

This problem persists into version 2.95. My original patches were created 
for this version. Program author has been informed of bug and of patches.
Comment 1 j. alan eldridge 2001-05-21 06:13:01 UTC 
Created attachment 19110 [details]
patch to close fds before exec
Comment 2 j. alan eldridge 2001-05-21 06:13:48 UTC 
Created attachment 19111 [details]
write debug out to stderr, unbuffer stdout so debugging is useful
Comment 3 j. alan eldridge 2001-05-21 06:14:39 UTC 
Created attachment 19112 [details]
updated spec file including my patches
Comment 4 j. alan eldridge 2001-05-21 06:15:58 UTC 
Created attachment 19113 [details]
a source RPM for 2.95 with my patches + the makefile patch
Comment 5 Tim Powers 2001-05-21 14:13:30 UTC 
I applied your patches for closing the fd, and for debugging. The new package
(with credit towards you) should show up in rawhide shortly.

Tim