Bug 416351
Summary: | setroubleshoot does not escape regex chars in suggested cmds | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | JoSH Lehan <krellan> |
Component: | setroubleshoot | Assignee: | John Dennis <jdennis> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | low | Docs Contact: | |
Priority: | low | ||
Version: | 8 | CC: | dwalsh, jneedle |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | setroubleshoot-plugins-2.0.4 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-01-31 17:52:35 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
JoSH Lehan
2007-12-08 06:40:02 UTC
I agree the suggested fix should be correct shell syntax. Can you please provide an example of where the filename contained regular expressions? By any chance was it something like socket:[123456]? Here is the filename: ~/.thunderbird/*.default/extensions/{c8961d25-7d90-4c7e-893b-400a5c882920}/platform/Linux_x86-gcc3/components/rmdBadCertListener.so I believe the { and } characters are what caused problems. BTW, this is the Remember Mismatched Domains extension for Mozilla Thunderbird. I did a bit of SELinux evangelism and contacted the author of this extension, and he agreed to recompile with -fPIC in order to work around the SELinux error message. *** Bug 430950 has been marked as a duplicate of this bug. *** Rather than escaping characters I've enclosed the necessary arguments in shell commands inside single quotes. This was easier and should be more readable. Dan: this was done in the plugins. In the future when we add new plugins or edit existing ones we need to remember to always quote shell arguments when the derive from a template substitution since we don't know what the substitution string might be. This has to be done in the individual plugin's there isn't anyway to automate the quoting. setroubleshoot-2.0.5-1.fc8,setroubleshoot-plugins-2.0.4-1.fc8 has been submitted as an update for Fedora 8 setroubleshoot-plugins-2.0.4-3.fc8,setroubleshoot-2.0.5-2.fc8 has been submitted as an update for Fedora 8 setroubleshoot-plugins-2.0.4-3.fc8, setroubleshoot-2.0.5-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. |