Bug 426641
| Summary: | Review Request: perl-Algorithm-CheckDigits - Perl extension to generate and test check digits | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Xavier Bachelot <xavier> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-12-23 19:24:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Xavier Bachelot
2007-12-23 16:02:11 UTC
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url c16aacf1770efa50c3db68959f4fae53 Algorithm-CheckDigits-0.48.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs t/checkdigits.....ok t/ecno............ok t/iban............ok t/imei............ok t/isbn13..........ok t/pod-coverage....ok t/pod.............ok t/upc.............ok t/valid...........ok All tests successful. Files=9, Tests=526, 1 wallclock secs ( 0.43 cusr + 0.06 csys = 0.49 CPU) + Package perl-Algorithm-CheckDigits-0.48-1.fc9 ->Provides: perl(Algorithm::CheckDigits) perl(Algorithm::CheckDigits::M07_001) perl(Algorithm::CheckDigits::M09_001) perl(Algorithm::CheckDigits::M10_001) perl(Algorithm::CheckDigits::M10_002) perl(Algorithm::CheckDigits::M10_003) perl(Algorithm::CheckDigits::M10_004) perl(Algorithm::CheckDigits::M10_005) perl(Algorithm::CheckDigits::M10_006) perl(Algorithm::CheckDigits::M10_008) perl(Algorithm::CheckDigits::M10_009) perl(Algorithm::CheckDigits::M10_010) perl(Algorithm::CheckDigits::M10_011) perl(Algorithm::CheckDigits::M11_001) perl(Algorithm::CheckDigits::M11_002) perl(Algorithm::CheckDigits::M11_003) perl(Algorithm::CheckDigits::M11_004) perl(Algorithm::CheckDigits::M11_006) perl(Algorithm::CheckDigits::M11_007) perl(Algorithm::CheckDigits::M11_008) perl(Algorithm::CheckDigits::M11_009) perl(Algorithm::CheckDigits::M11_010) perl(Algorithm::CheckDigits::M11_011) perl(Algorithm::CheckDigits::M11_012) perl(Algorithm::CheckDigits::M11_013) perl(Algorithm::CheckDigits::M11_015) perl(Algorithm::CheckDigits::M11_016) perl(Algorithm::CheckDigits::M11_017) perl(Algorithm::CheckDigits::M16_001) perl(Algorithm::CheckDigits::M23_001) perl(Algorithm::CheckDigits::M23_002) perl(Algorithm::CheckDigits::M43_001) perl(Algorithm::CheckDigits::M89_001) perl(Algorithm::CheckDigits::M97_001) perl(Algorithm::CheckDigits::M97_002) perl(Algorithm::CheckDigits::MBase_001) perl(Algorithm::CheckDigits::MBase_002) perl(Algorithm::CheckDigits::MBase_003) perl(Algorithm::CheckDigits::MXX_001) perl(Algorithm::CheckDigits::MXX_002) perl(Algorithm::CheckDigits::MXX_003) perl(Algorithm::CheckDigits::MXX_004) perl(Algorithm::CheckDigits::MXX_005) perl(Algorithm::CheckDigits::MXX_006) Requires: perl >= 0:5.006 perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Data::Dumper) perl(Exporter) perl(integer) perl(strict) perl(vars) perl(warnings) APPROVED. Thx for the review. You forgot to set the fedora-review flag, I did it. New Package CVS Request ======================= Package Name: perl-Algorithm-CheckDigits Short Description: Perl extension to generate and test check digits Owners: xavierb Branches: F-8 InitialCC: Cvsextras Commits: yes Xavier, Its not good that package submitter to set fedora-review flag. Otherwise most of package submitter will do that themselves and there will be no need of any official reviewer. So you should wait for reviewer to set it. I am sorry that I forgot that and when I come back to set I saw its already done by submitter which is not good. keep patience while reviewer set flag or ask him in review only first. setting fedora-review+ now. cvs done. Thanks for resetting the flag Parag. Sorry about that, I thought the comment was enough, but obviously it is not. I fully understand and agree what I did can cause trouble. Imported and built for devel and F-8. Thanks to both of you. Regards, Xavier |