Bug 426641 - Review Request: perl-Algorithm-CheckDigits - Perl extension to generate and test check digits
Review Request: perl-Algorithm-CheckDigits - Perl extension to generate and t...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-12-23 11:02 EST by Xavier Bachelot
Modified: 2007-12-23 14:24 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-12-23 14:24:33 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Xavier Bachelot 2007-12-23 11:02:11 EST
Spec URL: http://washington.kelkoo.net/fedora/SPECS/perl-Algorithm-CheckDigits.spec
SRPM URL: http://washington.kelkoo.net/fedora/SRPMS/perl-Algorithm-CheckDigits-0.48-1.fc8.src.rpm
Description: This module provides a number of methods to test and generate check digits.
Comment 1 Parag AN(पराग) 2007-12-23 12:46:25 EST
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
c16aacf1770efa50c3db68959f4fae53  Algorithm-CheckDigits-0.48.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
t/checkdigits.....ok
t/ecno............ok
t/iban............ok
t/imei............ok
t/isbn13..........ok
t/pod-coverage....ok
t/pod.............ok
t/upc.............ok
t/valid...........ok
All tests successful.
Files=9, Tests=526,  1 wallclock secs ( 0.43 cusr +  0.06 csys =  0.49 CPU)

+ Package perl-Algorithm-CheckDigits-0.48-1.fc9 ->Provides:
perl(Algorithm::CheckDigits) perl(Algorithm::CheckDigits::M07_001)
perl(Algorithm::CheckDigits::M09_001) perl(Algorithm::CheckDigits::M10_001)
perl(Algorithm::CheckDigits::M10_002) perl(Algorithm::CheckDigits::M10_003)
perl(Algorithm::CheckDigits::M10_004) perl(Algorithm::CheckDigits::M10_005)
perl(Algorithm::CheckDigits::M10_006) perl(Algorithm::CheckDigits::M10_008)
perl(Algorithm::CheckDigits::M10_009) perl(Algorithm::CheckDigits::M10_010)
perl(Algorithm::CheckDigits::M10_011) perl(Algorithm::CheckDigits::M11_001)
perl(Algorithm::CheckDigits::M11_002) perl(Algorithm::CheckDigits::M11_003)
perl(Algorithm::CheckDigits::M11_004) perl(Algorithm::CheckDigits::M11_006)
perl(Algorithm::CheckDigits::M11_007) perl(Algorithm::CheckDigits::M11_008)
perl(Algorithm::CheckDigits::M11_009) perl(Algorithm::CheckDigits::M11_010)
perl(Algorithm::CheckDigits::M11_011) perl(Algorithm::CheckDigits::M11_012)
perl(Algorithm::CheckDigits::M11_013) perl(Algorithm::CheckDigits::M11_015)
perl(Algorithm::CheckDigits::M11_016) perl(Algorithm::CheckDigits::M11_017)
perl(Algorithm::CheckDigits::M16_001) perl(Algorithm::CheckDigits::M23_001)
perl(Algorithm::CheckDigits::M23_002) perl(Algorithm::CheckDigits::M43_001)
perl(Algorithm::CheckDigits::M89_001) perl(Algorithm::CheckDigits::M97_001)
perl(Algorithm::CheckDigits::M97_002) perl(Algorithm::CheckDigits::MBase_001)
perl(Algorithm::CheckDigits::MBase_002) perl(Algorithm::CheckDigits::MBase_003)
perl(Algorithm::CheckDigits::MXX_001) perl(Algorithm::CheckDigits::MXX_002)
perl(Algorithm::CheckDigits::MXX_003) perl(Algorithm::CheckDigits::MXX_004)
perl(Algorithm::CheckDigits::MXX_005) perl(Algorithm::CheckDigits::MXX_006)

Requires: perl >= 0:5.006 perl(:MODULE_COMPAT_5.8.8) perl(Carp)
perl(Data::Dumper) perl(Exporter) perl(integer) perl(strict) perl(vars)
perl(warnings)

APPROVED.
  
Comment 2 Xavier Bachelot 2007-12-23 13:04:20 EST
Thx for the review. You forgot to set the fedora-review flag, I did it.

New Package CVS Request
=======================
Package Name: perl-Algorithm-CheckDigits
Short Description: Perl extension to generate and test check digits
Owners: xavierb
Branches: F-8
InitialCC: 
Cvsextras Commits: yes
Comment 3 Parag AN(पराग) 2007-12-23 13:22:35 EST
Xavier,
 Its not good that package submitter to set fedora-review flag. Otherwise most
of package submitter will do that themselves and there will be no need of any 
official reviewer. So you should wait for reviewer to set it. I am sorry that I
forgot that and when I come back to set I saw its already done by submitter
which is not good.

 keep patience while reviewer set flag or ask him in review only first.
setting fedora-review+ now.
Comment 4 Kevin Fenzi 2007-12-23 13:27:42 EST
cvs done. 

Thanks for resetting the flag Parag.
Comment 5 Xavier Bachelot 2007-12-23 14:24:33 EST
Sorry about that, I thought the comment was enough, but obviously it is not. I
fully understand and agree what I did can cause trouble.

Imported and built for devel and F-8.

Thanks to both of you.

Regards,
Xavier


Note You need to log in before you can comment on or make changes to this bug.