Bug 427342
| Summary: | Review Request: jday - A simple command to convert calendar dates to julian dates | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Huzaifa S. Sidhpurwala <huzaifas> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, kevin, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-01-12 15:07:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Huzaifa S. Sidhpurwala
2008-01-03 09:31:58 UTC
You need some SPEC cleanups and follow packaging guidelines as per given at http://fedoraproject.org/wiki/Packaging/Guidelines 1) change source URL from http://jaist.dl.sourceforge.net/sourceforge/jday/jday-2.4.tar.gz to http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz check more on it http://fedoraproject.org/wiki/Packaging/SourceURL 2) SHOULD follow macros. READ more on it http://fedoraproject.org/wiki/Packaging/Guidelines#head-e205651a2c97a6857ab748c20d8ea60c25e3a520/mono 3) ldconfig usage should be as per given http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-d0dbcb7eec27622a21df280009c5b089b02f5bef 4) you need to add -devel subpackage which includes header files and .so files provide updated package links, updating release tag and adding correct changelog of what change you did in SPEC. 5) Don't include .a and .la files in %files. Fedora packaging guidelines suggests http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4bcce24cb711266557ad7 6) usage of make should be as per given at http://fedoraproject.org/wiki/Packaging/Guidelines#head-525c7d76890cb22df33b759c65c35c82bf434d2e 7) This package does not honor compiler flags look at http://fedoraproject.org/wiki/Packaging/Guidelines#head-8b14098227aebff1cf6188939e9d0877295ac448 I have made the required changed to the spec please review the new spec at: http://www.geocities.com/fatema_mhs/jday.spec.txt and SRPM at: http://www.geocities.com/fatema_mhs/jday-2.4-1.fc8.src.rpm 1) You need to follow Source URL (macro using) as http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz 2) Don't use like this %_bindir/dbd use clean and not confusing and accepted way of writing in spec %{_bindir}/dbd 3)Also, I see your spec file ends with .txt in SPEC url you provides. any reason? SPEC file should end with .spec only. Made the necessary changes as requested. The reason why i am calling the spec file as spec.txt because i am using free yahoo web hosting to upload my files and it does not accept .spec when uploading the files. Again: SPEC File: http://www.geocities.com/fatema_mhs/jday.spec.txt SRPM: http://www.geocities.com/fatema_mhs/jday-2.4-1.f8.srpm Thanks for updates. Will sponsor you after I see enough reviews from you to other people's packages. and then review this officially also. Review: + package builds in mock (development i386). + rpmlint is silent for RPM But NOT for RPM. jday.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 1) ==>cosmetic message. + source files match upstream url 817af56005d1346677271ed2fab63ef5 jday-2.4.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + jday.pc file present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package jday-2.4-1.fc9 -> Provides: libjday.so.2 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libjday.so.2 rtld(GNU_HASH) + Package jday-devel-2.4-1.fc9 -> Requires: jday = 2.4-1.fc9 libjday.so.2 + Not a GUI App. APPROVED. New Package CVS Request ======================= Package Name: jday Short Description: A Simple command to convert calendar dates to Julian dates Owners: huzaifas Branches: F-8 InitialCC: huzaifsa Cvsextras Commits: no cvs done. Any reason to now allow cvsextras commits? No, Sorry i copy pasted this from somewhere else and this is an oversight Can you do this please. cvsextras added. Thanks. Closing this Review ticket as this package is successfully built on koji for requested branches. |