Red Hat Bugzilla – Bug 427342
Review Request: jday - A simple command to convert calendar dates to julian dates
Last modified: 2008-01-12 10:07:47 EST
Spec URL: http://www.geocities.com/fatema_mhs/jday.spec.txt
SRPM URL: http://www.geocities.com/fatema_mhs/jday-2.4-0.fc8.src.rpm
A simple command to convert calendar dates to julian dates.
Quite useful in timing situations where you need elapsed time between dates.
Also useful for astronomy applications.
I want to include this in the astronomy spin of fedora.
You need some SPEC cleanups and follow packaging guidelines as per given at
1) change source URL from
check more on it http://fedoraproject.org/wiki/Packaging/SourceURL
2) SHOULD follow macros. READ more on it
3) ldconfig usage should be as per given
4) you need to add -devel subpackage which includes header files and .so files
provide updated package links, updating release tag and adding correct changelog
of what change you did in SPEC.
5) Don't include .a and .la files in %files. Fedora packaging guidelines
6) usage of make should be as per given at
7) This package does not honor compiler flags look at
I have made the required changed to the spec please review the new spec at:
and SRPM at:
1) You need to follow Source URL (macro using) as
2) Don't use like this
use clean and not confusing and accepted way of writing in spec
3)Also, I see your spec file ends with .txt in SPEC url you provides. any reason?
SPEC file should end with .spec only.
Made the necessary changes as requested.
The reason why i am calling the spec file as spec.txt because i am using free
yahoo web hosting to upload my files and it does not accept .spec when uploading
SPEC File: http://www.geocities.com/fatema_mhs/jday.spec.txt
Thanks for updates.
Will sponsor you after I see enough reviews from you to other people's packages.
and then review this officially also.
+ package builds in mock (development i386).
+ rpmlint is silent for RPM But NOT for RPM.
jday.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 1)
+ source files match upstream url
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ Compiler flags used correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no static libraries.
+ jday.pc file present.
+ -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ ldconfig scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package jday-2.4-1.fc9 ->
Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3)
libc.so.6(GLIBC_2.3.4) libjday.so.2 rtld(GNU_HASH)
+ Package jday-devel-2.4-1.fc9 ->
Requires: jday = 2.4-1.fc9 libjday.so.2
+ Not a GUI App.
New Package CVS Request
Package Name: jday
Short Description: A Simple command to convert calendar dates to Julian dates
Cvsextras Commits: no
Any reason to now allow cvsextras commits?
Sorry i copy pasted this from somewhere else and this is an oversight
Can you do this please.
cvsextras added. Thanks.
Closing this Review ticket as this package is successfully built on koji for