Bug 427411
| Summary: | Review Request: common-lisp-controller - Common Lisp source and compiler manager | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Anthony Green <green> |
| Component: | Package Review | Assignee: | Michel Lind <michel> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, pbrobinson, rdieter |
| Target Milestone: | --- | Flags: | michel:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-10-11 14:51:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 427391 | ||
| Bug Blocks: | |||
|
Description
Anthony Green
2008-01-03 18:01:37 UTC
Ready for approval, contigent on three things being fixed (listed below): - remove tabs - check with legal on licensing (looks more liberal than LGPL so I'm personally OK with it) - include debian/copyright MUST • rpmlint: - mixed use of space and tabs (trivial) • package name: OK • spec file name: OK • package guideline-compliant: OK • license complies with guidelines LLGPL not in pre-approved list. Should legal take a look at it? • license field accurate: OK • license file not deleted: FAIL please include debian/copyright file in %doc • spec in US English: OK • spec legible: OK • source matches upstream: OK • builds under >= 1 archs, others excluded: noarch, OK • build dependencies complete: OK • own all directories: OK • no dupes in %files: OK • permission: OK • %clean RPM_BUILD_ROOT: OK • macros used consistently: OK • Package contains code: OK • clean buildroot before install: OK • filenames UTF-8: OK SHOULD • package build in mock on all architectures: OK • package functioned as described: suggestion on how to test? • scriplets are sane: OK • require package not files: OK (In reply to comment #1) > Ready for approval, contigent on three things being fixed (listed below): > - remove tabs > - check with legal on licensing (looks more liberal than LGPL so I'm personally > OK with it) > - include debian/copyright > Thanks. I've just sent a note to fedora-legal-list. AG (In reply to comment #1) > Ready for approval, contigent on three things being fixed (listed below): > - remove tabs > - check with legal on licensing (looks more liberal than LGPL so I'm personally > OK with it) > - include debian/copyright LLGPL is on the approved license list now. I'll make the two other changes and add this. Thanks! AG Here are the updated files: Spec URL: http://spindazzle.org/Fedora/common-lisp-controller.spec SRPM URL: http://spindazzle.org/Fedora/common-lisp-controller-6.15-2.fc9.src.rpm Note that I also upgraded from 6.12 to 6.15. Approved? Thanks, AG (In reply to comment #1) > Ready for approval, contigent on three things being fixed (listed below): > - remove tabs > - check with legal on licensing (looks more liberal than LGPL so I'm personally > OK with it) > - include debian/copyright Michael - these were all fixed. I have a ton of Common Lisp packages depending on this approval. I think we're done now, but I think I need you to flip the bit before I request my cvs tree. Thanks! Somehow missed the bugzilla notification, sorry. Yes, all issues are resolved. APPROVED. New Package CVS Request ======================= Package Name: common-lisp-controller Short Description: Common Lisp source and compiler manager Owners: green Branches: F-9 InitialCC: cvs done. Closing - in rawhide Package Change Request ====================== Package Name: common-lisp-controller New Branches: el6 Owners: green InitialCC: rdieter I'd like to bring common-lisp-controller into el6 for sbcl and other lisps. Git done (by process-git-requests). Package Change Request ====================== Package Name: common-lisp-controller New Branches: epel7 Owners: green InitialCC: rdieter Git done (by process-git-requests). |