Bug 427966
| Summary: | OpenOffice.org crashes on close of ftp:// url | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Edouard Bourguignon <madko> | ||||
| Component: | curl | Assignee: | Jindrich Novy <jnovy> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 8 | CC: | daniel, jnavrati, opensource, pknirsch, wtogami | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 7.17.1-2.fc8 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-02-16 02:09:54 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Edouard Bourguignon
2008-01-08 09:47:14 UTC
Just to attempt to get close to this setup for testing, was it an anonymous ftp or a username/password one ? And did you have write access to the opened file ? And did you make any modifications and try and use save, or was it just open it, read it and then close OOo ? I don't get an immediate crash but I do get invalid closes on valgrind /usr/lib64/openoffice.org/program/soffice.bin ftp://username:password@somewhere/test.odt from libcurl and the attached patch to curl makes them go away Created attachment 291052 [details]
patch to curl
Applied, thanks! it was on an anonymous ftp, no modification on the file, just open and close it. curl-7.17.1-2.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update curl' curl-7.17.1-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. Allow me to express my disappointment in you. I've tried to participate and help and assist in your bug tracker, and as a thank-you you patch and fix curl and keep the patch "secret" in this way. (Me being the maintainer and primary author of curl and libcurl "upstream".) It was only due to a keep user that notified our mailing list that made us aware of your patch here. This is not a very open-source way of doing things, and you should know this. (In reply to comment #8) > Allow me to express my disappointment in you. I've tried to participate and help > and assist in your bug tracker, and as a thank-you you patch and fix curl and > keep the patch "secret" in this way. (Me being the maintainer and primary author > of curl and libcurl "upstream".) It is announced on the first line in changelog in the F8 update (also in the update release notes) and in rawhide as well. Both F8 and rawhide repositories are publicly available and to hide the patch in any way was never my intention. Why? > It was only due to a keep user that notified our mailing list that made us aware > of your patch here. This is not a very open-source way of doing things, and you > should know this. If you wish to be notified about patches going into Fedora for curl: Please apply for "watchcommits" here: https://admin.fedoraproject.org/pkgdb/packages/name/curl after that you will receive all Fedora commits to curl by mail. It is not very frequent so you won't get spammed. You can also apply for "watchbugzilla" where you will be in default Cc for all curl bugs reported to me or even "commit" if you wish to have commit access in Fedora curl. I can give you approval immediately for all this. I propose this to you since there exist only curl-users and curl-library mailing lists. They are for a wide audience and I don't want to receive more spam than is needed, what is the reason that I'm not subscribed to the lists and don't contribute to them. In other projects such as Midnight Commander, there exist mc for general discussion and mc-devel for patches and development discussion/patches/technical RFEs. It would be nice to see such list for curl (say curl-devel or curl-patches) and I'd be happy to subscribe/contribute to it if needed. Regarding upstreaming: It is best practices[1,2] to send patches within Fedora to upstream and not wait for them to notice them. It is also mentioned in the Fedora Objectives[3]: | To do as much of the development work as possible directly in the upstream | packages. We will in general prefer moving to a newer version for updates rather | than backport fixes. [1] https://fedoraproject.org/wiki/Packaging/PatchUpstreamStatus [2] https://fedoraproject.org/wiki/PackageMaintainers/WhyUpstream [3] https://fedoraproject.org/wiki/Objectives Jindrich, The "making available" argument is not good enough. It is an expectation of Fedora developers to submit patches directly to upstream development projects. |