Bug 428360
| Summary: | Review Request: pywbxml - Python wrapper for wbxml2 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andreas Bierfert <andreas.bierfert> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-01-13 00:04:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 428361 | ||
|
Description
Andreas Bierfert
2008-01-11 00:35:56 UTC
koji build failed with log http://koji.fedoraproject.org/koji/getfile?taskID=344201&name=build.log Add missing BR: libxml2-devel expat-devel Actually these should be pulled in by wbxml2-devel... I fixed it. wbxml2-0.9.2-12.fc9 currently building for rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=344368 Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 6a1181b7be09ba69fe6768a0f6156416 pywbxml-0.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package pywbxml-0.1-1.fc9 => Provides: pywbxml.so Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libwbxml2.so.0 libxml2.so.2 python(abi) = 2.5 SHOULD: Change source URL to http://downloads.sourceforge.net/synce/%{name}-%{version}.tar.gz APPROVED. Will change upon import. Thanks yet again for another review. New Package CVS Request ======================= Package Name: pywbxml Short Description: Python wrapper for wbxml2 Owners: awjb Branches: F-8 Cvsextras Commits: yes cvs done. |