Bug 428360 - Review Request: pywbxml - Python wrapper for wbxml2
Review Request: pywbxml - Python wrapper for wbxml2
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
:
Depends On:
Blocks: 428361
  Show dependency treegraph
 
Reported: 2008-01-10 19:35 EST by Andreas Bierfert
Modified: 2008-01-12 19:04 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-01-12 19:04:58 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Andreas Bierfert 2008-01-10 19:35:56 EST
Spec URL: http://fedora.lowlatency.de/review/pywbxml.spec
SRPM URL: http://fedora.lowlatency.de/review/pywbxml-0.1-1.fc9.src.rpm
Description:
Python wrapper for wbxml2

Needs latest wbxml2 (0.9.2-10.fc9) with synce patches to build (should be in next rawhide push or see http://koji.fedoraproject.org/koji/taskinfo?taskID=340408)
Comment 1 Parag AN(पराग) 2008-01-12 07:39:30 EST
koji build failed with log
http://koji.fedoraproject.org/koji/getfile?taskID=344201&name=build.log
Comment 2 Parag AN(पराग) 2008-01-12 09:18:13 EST
Add missing BR: libxml2-devel expat-devel
Comment 3 Andreas Bierfert 2008-01-12 09:59:01 EST
Actually these should be pulled in by wbxml2-devel... I fixed it.
wbxml2-0.9.2-12.fc9 currently building for rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=344368
Comment 4 Parag AN(पराग) 2008-01-12 10:51:48 EST
Review:
+ package builds in mock (rawhide i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
6a1181b7be09ba69fe6768a0f6156416  pywbxml-0.1.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package pywbxml-0.1-1.fc9 =>
   Provides: pywbxml.so
   Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3)
libwbxml2.so.0 libxml2.so.2 python(abi) = 2.5 

 SHOULD:
   Change source URL to
http://downloads.sourceforge.net/synce/%{name}-%{version}.tar.gz

APPROVED.

Comment 5 Andreas Bierfert 2008-01-12 11:04:30 EST
Will change upon import. Thanks yet again for another review.

New Package CVS Request
=======================
Package Name: pywbxml
Short Description: Python wrapper for wbxml2
Owners: awjb
Branches: F-8
Cvsextras Commits: yes
Comment 6 Kevin Fenzi 2008-01-12 15:41:17 EST
cvs done.

Note You need to log in before you can comment on or make changes to this bug.