Bug 428972
Summary: | Review Request: obex-data-server - a D-Bus service for Obex access | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Bastien Nocera <bnocera> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-01-22 14:40:11 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Bastien Nocera
2008-01-16 15:17:51 UTC
Updated to -2. http://people.redhat.com/bnocera/obex-data-server/obex-data-server-0.01-2.16012007.fc8.src.rpm May I know difference between gnome-obex-server command from gnome-bluetooth and this package? rpmlint on RPM gave => obex-data-server.i386: W: spurious-executable-perm /usr/share/doc/obex-data-server-0.01/ods-session-test.py obex-data-server.i386: W: non-conffile-in-etc /etc/dbus-1/system.d/obex-data-server.conf obex-data-server.i386: W: spurious-executable-perm /usr/share/doc/obex-data-server-0.01/ods-server-test.py obex-data-server.i386: W: summary-not-capitalized a D-Bus service for Obex access obex-data-server.i386: W: no-url-tag obex-data-server.i386: W: doc-file-dependency /usr/share/doc/obex-data-server-0.01/ods-server-test.py /usr/bin/python obex-data-server.i386: W: doc-file-dependency /usr/share/doc/obex-data-server-0.01/ods-session-test.py /usr/bin/python ==> You may like to remove executable permissions for ods-session-test.py and ods-server-test.py (In reply to comment #2) > May I know difference between gnome-obex-server command from gnome-bluetooth and > this package? gnome-obex-server will soon die die die. This is a D-Bus service though, not a GUI application. It allows apps that do Obex (FTP and Push, server and client) to have a simple API. > ==> You may like to remove executable permissions for ods-session-test.py and > ods-server-test.py Will do. Updated to -3. http://people.redhat.com/bnocera/obex-data-server/obex-data-server-0.01-3.16012007.fc8.src.rpm It doesn't check for libtool, but uses it anyway. Updated SRPM: http://people.redhat.com/bnocera/obex-data-server/obex-data-server-0.01-4.16012007.fc8.src.rpm Parag, any news on the review? rpmlint reported following => obex-data-server.i386: W: non-conffile-in-etc /etc/dbus-1/system.d/obex-data-server.conf A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file. obex-data-server.i386: W: summary-not-capitalized a D-Bus service for Obex access Summary doesn't begin with a capital letter. obex-data-server.i386: W: no-url-tag The URL tag is missing. I think you need to add BR: python also as build log showed me usr/lib/rpm/pythondeps.sh: line 8: python: command not found See http://koji.fedoraproject.org/koji/getfile?taskID=360278&name=build.log (In reply to comment #8) > rpmlint reported following => > obex-data-server.i386: W: non-conffile-in-etc > /etc/dbus-1/system.d/obex-data-server.conf > A non-executable file in your package is being installed in /etc, but is not > a configuration file. All non-executable files in /etc should be configuration > files. Mark the file as %config in the spec file. That's expected, it's not a configuration file (ie. it shouldn't be modified). > obex-data-server.i386: W: summary-not-capitalized a D-Bus service for Obex access > Summary doesn't begin with a capital letter. Remove the "a". > obex-data-server.i386: W: no-url-tag > The URL tag is missing. Added a link to the upstream blog. (In reply to comment #9) > I think you need to add BR: python also as build log showed me > usr/lib/rpm/pythondeps.sh: line 8: python: command not found > > See http://koji.fedoraproject.org/koji/getfile?taskID=360278&name=build.log That's a missing dependency in rpmbuild, not in my package. I updated the spec file, and made the dbus conf file a conffile, although I'm not sure it should be... http://people.redhat.com/bnocera/obex-data-server/obex-data-server.spec Review: + package builds in mock (rawhide i386). - rpmlint is silent for SRPM But NOT for RPM. obex-data-server.i386: W: conffile-without-noreplace-flag /etc/dbus-1/system.d/obex-data-server.conf ==> Ok + source files match upstream url though got different checksum Packaged tarball => 765b49276d3f21858cdf7d29f301ae48 obex-data-server-16012007.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + Compiler flags used correctly. + defattr usage is correct. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package obex-data-server-0.01-5.16012007.fc9 => Provides: config(obex-data-server) = 0.01-5.16012007.fc9 Requires: config(obex-data-server) = 0.01-5.16012007.fc9 libbluetooth.so.2 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libdbus-1.so.3 libdbus-glib-1.so.2 libglib-2.0.so.0 libgobject-2.0.so.0 libopenobex.so.1 libusb-0.1.so.4 + Not a GUI APP. APPROVED New Package CVS Request ======================= Package Name: obex-data-server Short Description: D-Bus service for Obex access Owners: hadess Branches: devel InitialCC: Cvsextras Commits: yes cvs done. In rawhide now. Thanks! |