Bug 429112

Summary: Review Request: pigment-python - Python bindings to the Pigment Media Center Toolkit
Product: [Fedora] Fedora Reporter: Matthias Saou <matthias>
Component: Package ReviewAssignee: Mamoru TASAKA <mtasaka>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, mtasaka, notting
Target Milestone: ---Flags: mtasaka: fedora‑review+
kevin: fedora‑cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-03-22 15:31:18 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Bug Depends On:    
Bug Blocks: 429590    

Description Matthias Saou 2008-01-17 08:13:27 EST
Spec URL: http://thias.fedorapeople.org/review/pigment-python/pigment-python.spec
SRPM URL: http://thias.fedorapeople.org/review/pigment-python/pigment-python-0.3.1-1.src.rpm
Description:
Pigment is a toolkit for writing Media Center software.
These are the Python bindings for Pigment.

Note : The python bindings have been split out of the main "pigment" package between the 0.3.2 and 0.3.3 releases, so this new separate package is now required to get the same level of functionality (required by "elisa").
Comment 1 Mamoru TASAKA 2008-02-08 10:24:51 EST
This does not build.
http://koji.fedoraproject.org/koji/taskinfo?taskID=403358
Comment 2 Matthias Saou 2008-02-08 14:09:48 EST
Indeed. I've added the gstreamer-devel build requirement and tested a build
making sure I wasn't keeping any packages in the build root (which I probably
did the first time without realizing). Worked for me. I also updated to the
latest version.

Find the new 0.3.2-1 in the same location.

Note that you might need to rebuild pigment 0.3.4 before. I've committed it to
CVS on the devel branch, although I won't build it until this package is
reviewed and approved, since it would be a regression otherwise.
Comment 3 Mamoru TASAKA 2008-02-09 11:43:11 EST
(In reply to comment #2)
> Note that you might need to rebuild pigment 0.3.4 before. I've committed it to
> CVS on the devel branch, although I won't build it until this package is
> reviewed and approved, since it would be a regression otherwise.

Well, then I don't want to review this because I want to make it
sure that the rebuild succeeds on all archs on koji (there are many cases
in which  problems are found on other than i386 arch).
BTW don't you want to see the "regression" until this package gets approved
even if it is on rawhide?
Comment 4 Matthias Saou 2008-02-11 09:16:33 EST
OK, I guess it won't be too much of a problem to "break" what requires pigment
in Rawhide for a few days, since AFAIK only elisa requires it. I've just
triggered a new build of pigment 0.3.4 in Rawhide, so you should be able to test
a rebuild of pigment-python against it now.
Comment 5 Mamoru TASAKA 2008-02-11 12:14:18 EST
Well,
! I recommend to use
  make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
  to keep timestamps on installed files as much as possible.
  This method usually works for recent autotool-based Makefiles.

  http://koji.fedoraproject.org/koji/taskinfo?taskID=415494

Other things are okay
* source coincides with upstream
* spec file okay
* actually builds
  http://koji.fedoraproject.org/koji/taskinfo?taskID=415328
* can be installed
* Requires okay
-------------------------------------------------------------------------
             This package (pigment-python) is APPROVED by me
--------------------------------------------------------------------------
Comment 6 Matthias Saou 2008-02-13 05:41:43 EST
Thanks! Mamoru : I've added the INSTALL="install -p".

New Package CVS Request
=======================
Package Name: pigment-python
Short Description: Python bindings to the Pigment Media Center Toolkit
Owners: thias
Branches: F-7 F-8 EL-5
InitialCC:
Cvsextras Commits: yes
Comment 7 Kevin Fenzi 2008-02-13 12:33:13 EST
cvs done.
Comment 8 Mamoru TASAKA 2008-02-22 12:31:38 EST
What is the status of this bug?
Comment 9 Matthias Saou 2008-02-23 18:34:22 EST
Rebuilding for devel now, sorry. Once further tested, I'll also update pigment
on the other current branches, in order to rebuild pigment-python, and be able
to update elisa at last (bug #429590).
Comment 10 Matthias Saou 2008-03-22 15:31:18 EDT
The Elisa update is still pending, since new plugin packages will have to be
submitted, but I'll close this review since pigment-python has been rebuilt and
is available (for devel for now).