Bug 429199

Summary:	Review Request: polyester3 - A style for KDE3
Product:	[Fedora] Fedora	Reporter:	Sebastian Vahl <fedora>
Component:	Package Review	Assignee:	Rex Dieter <rdieter>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, kevin, notting, rdieter
Target Milestone:	---	Flags:	rdieter: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-02-14 18:57:53 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sebastian Vahl 2008-01-17 21:52:54 UTC

Spec URL: http://svahl.fedorapeople.org/polyester3/polyester3.spec
SRPM URL: http://svahl.fedorapeople.org/polyester3/polyester3-1.0.3-1.fc8.src.rpm
Description: 
A widget style aimed to be 
a good balance between eyecandy and simplicity.

Note: This is mostly the same package as the already existing polyester-1.0.2 (from F7/8). It's the KDE3 version of the widget style. polyester in rawhide is upgraded to the kde4 version. This package should provide the same look also for KDE3 apps that are used in a KDE4 session. It's patched to not build the kwin theme.

Note about the name: The "3" in the name should show that this package is for KDE3. 

Old review request: bug #222220
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=355554

Comment 1 Rex Dieter 2008-02-05 19:32:00 UTC

Not much has changed since previous review, so I'll be brief:

clean, simple.

source matches upstream,
673d21db31eeaedf9b63cd09f6b247a8  polyester-1.0.3.tar.bz2

scratch build was already pruned, so did a local build, which is 
rpmlint-clean.

All I see:

1.  SHOULD: I'd much prefer avoiding the use of Conflicts here.  It will only 
help a rare corner case.  I'll leave that to you.


APPROVED.

Comment 2 Sebastian Vahl 2008-02-05 21:12:55 UTC

(In reply to comment #1)
> All I see:
> 
> 1.  SHOULD: I'd much prefer avoiding the use of Conflicts here.  It will only 
> help a rare corner case.  I'll leave that to you.

But it won't hurd so I leave it in the spec.

> APPROVED.

Thanks!

Comment 3 Sebastian Vahl 2008-02-05 21:15:07 UTC

New Package CVS Request
=======================
Package Name: polyester3
Short Description: A style for KDE3
Owners: svahl
Branches: 
InitialCC: 
Cvsextras Commits: no

Comment 4 Kevin Fenzi 2008-02-06 00:54:30 UTC

cvs done. 

Any particular reason for the cvsextras commits: no?

Comment 5 Sebastian Vahl 2008-02-14 18:57:53 UTC

Imported and built some time ago. Closing.