Bug 429333

Summary:	Review Request: kscope - KDE front-end to Cscope
Product:	[Fedora] Fedora	Reporter:	Tom "spot" Callaway <tcallawa>
Component:	Package Review	Assignee:	Rex Dieter <rdieter>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, rdieter
Target Milestone:	---	Flags:	rdieter: fedora-review+ tcallawa: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-01-20 22:20:32 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tom "spot" Callaway 2008-01-18 19:01:49 UTC

Spec URL: http://www.auroralinux.org/people/spot/review/new/kscope.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/new/kscope-1.6.1-1.fc9.src.rpm
Description: 
KScope is a KDE front-end to Cscope. It provides a source-editing
environment for large C projects, such as the Linux kernel.

KScope is by no means intended to be a replacement to any of the leading
Linux/KDE IDEs, such as KDevelop. First of all, it is not an Integrated
Development Environment: it does not provide the usual write/compile/debug
cycle supported by most IDE's. Instead, KScope is focused on source
editing and analysis.

Comment 1 Rex Dieter 2008-01-18 20:54:24 UTC

2 Quick-n-dirty suggestions
1.  use desktop-file-install on .desktop file, with final location being 
(something like): %_datadir/applications/kde/kscope.desktop
(you may need to add a category or 2).
2.  drop Requires: kdelibs-common 
(it'll get pulled in by the default kde runtime pkgs)

Comment 2 Rex Dieter 2008-01-18 20:55:06 UTC

I'll get started on more of the formal stuff in a bit...

Comment 3 Rex Dieter 2008-01-18 21:14:57 UTC

3.  SHOULD: drop libtool hacks, use
%configure --disable-rpath 
instead

4.  MUST: add missing BR: kdebase3-devel (links against libkate from 
kdebase(3))

src.rpm and locally built x86_64 pkgs are rpmlint clean (other than harmless 
warning about dangling ../common symlink).

tested local built rpm, app launches/runs ok.


Consider 1-4, and I'll approve this.

Comment 4 Rex Dieter 2008-01-18 21:16:54 UTC

submitted scratch build (w/ items 3,4 fixed) for giggles:
http://koji.fedoraproject.org/koji/taskinfo?taskID=357919

Comment 5 Tom "spot" Callaway 2008-01-20 20:54:45 UTC

1-4 fixed:

New SPEC: http://www.auroralinux.org/people/spot/review/new/kscope.spec
New SRPM:
http://www.auroralinux.org/people/spot/review/new/kscope-1.6.1-2.fc9.src.rpm

Comment 6 Rex Dieter 2008-01-20 21:17:53 UTC

Close enough, APPROVED.

1 small thing (I'll leave it to you to address before building anything) 
regarding d-f-i usage, you used:
--vendor="fedora" ... --dir $RPM_BUILD_ROOT%{_datadir}/applications/kde
in effect having 2 vendors (fedora prefix + kde dir prefix), I'd suggest using
--vendor="" ... --dir $RPM_BUILD_ROOT%{_datadir}/applications/kde
instead.

Comment 7 Tom "spot" Callaway 2008-01-20 22:00:48 UTC

New Package CVS Request
=======================
Package Name: kscope
Short Description: KDE front-end to Cscope
Owners: spot
Branches: F-7 F-8 EL-4 EL-5 
InitialCC: 
Cvsextras Commits: yes

Comment 8 Rex Dieter 2008-01-20 22:06:58 UTC

noting the request for epel branches: only fedora kde packages include Provides
for kdelibs3/kdebase3, for rhel, you'll need kdelibs/kdebase, respectively.

Comment 9 Tom "spot" Callaway 2008-01-20 22:08:12 UTC

Good to know, thanks. 

cvs done.

Comment 10 Tom "spot" Callaway 2008-01-20 22:20:32 UTC

Builds away, thanks for the quick review.