Hide Forgot
Spec URL: http://www.auroralinux.org/people/spot/review/new/kscope.spec SRPM URL: http://www.auroralinux.org/people/spot/review/new/kscope-1.6.1-1.fc9.src.rpm Description: KScope is a KDE front-end to Cscope. It provides a source-editing environment for large C projects, such as the Linux kernel. KScope is by no means intended to be a replacement to any of the leading Linux/KDE IDEs, such as KDevelop. First of all, it is not an Integrated Development Environment: it does not provide the usual write/compile/debug cycle supported by most IDE's. Instead, KScope is focused on source editing and analysis.
2 Quick-n-dirty suggestions 1. use desktop-file-install on .desktop file, with final location being (something like): %_datadir/applications/kde/kscope.desktop (you may need to add a category or 2). 2. drop Requires: kdelibs-common (it'll get pulled in by the default kde runtime pkgs)
I'll get started on more of the formal stuff in a bit...
3. SHOULD: drop libtool hacks, use %configure --disable-rpath instead 4. MUST: add missing BR: kdebase3-devel (links against libkate from kdebase(3)) src.rpm and locally built x86_64 pkgs are rpmlint clean (other than harmless warning about dangling ../common symlink). tested local built rpm, app launches/runs ok. Consider 1-4, and I'll approve this.
submitted scratch build (w/ items 3,4 fixed) for giggles: http://koji.fedoraproject.org/koji/taskinfo?taskID=357919
1-4 fixed: New SPEC: http://www.auroralinux.org/people/spot/review/new/kscope.spec New SRPM: http://www.auroralinux.org/people/spot/review/new/kscope-1.6.1-2.fc9.src.rpm
Close enough, APPROVED. 1 small thing (I'll leave it to you to address before building anything) regarding d-f-i usage, you used: --vendor="fedora" ... --dir $RPM_BUILD_ROOT%{_datadir}/applications/kde in effect having 2 vendors (fedora prefix + kde dir prefix), I'd suggest using --vendor="" ... --dir $RPM_BUILD_ROOT%{_datadir}/applications/kde instead.
New Package CVS Request ======================= Package Name: kscope Short Description: KDE front-end to Cscope Owners: spot Branches: F-7 F-8 EL-4 EL-5 InitialCC: Cvsextras Commits: yes
noting the request for epel branches: only fedora kde packages include Provides for kdelibs3/kdebase3, for rhel, you'll need kdelibs/kdebase, respectively.
Good to know, thanks. cvs done.
Builds away, thanks for the quick review.