Bug 429333 - Review Request: kscope - KDE front-end to Cscope
Review Request: kscope - KDE front-end to Cscope
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Rex Dieter
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-18 14:01 EST by Tom "spot" Callaway
Modified: 2008-01-20 17:20 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-01-20 17:20:32 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
rdieter: fedora‑review+
tcallawa: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Tom "spot" Callaway 2008-01-18 14:01:49 EST
Spec URL: http://www.auroralinux.org/people/spot/review/new/kscope.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/new/kscope-1.6.1-1.fc9.src.rpm
Description: 
KScope is a KDE front-end to Cscope. It provides a source-editing
environment for large C projects, such as the Linux kernel.

KScope is by no means intended to be a replacement to any of the leading
Linux/KDE IDEs, such as KDevelop. First of all, it is not an Integrated
Development Environment: it does not provide the usual write/compile/debug
cycle supported by most IDE's. Instead, KScope is focused on source
editing and analysis.
Comment 1 Rex Dieter 2008-01-18 15:54:24 EST
2 Quick-n-dirty suggestions
1.  use desktop-file-install on .desktop file, with final location being 
(something like): %_datadir/applications/kde/kscope.desktop
(you may need to add a category or 2).
2.  drop Requires: kdelibs-common 
(it'll get pulled in by the default kde runtime pkgs)
Comment 2 Rex Dieter 2008-01-18 15:55:06 EST
I'll get started on more of the formal stuff in a bit...
Comment 3 Rex Dieter 2008-01-18 16:14:57 EST
3.  SHOULD: drop libtool hacks, use
%configure --disable-rpath 
instead

4.  MUST: add missing BR: kdebase3-devel (links against libkate from 
kdebase(3))

src.rpm and locally built x86_64 pkgs are rpmlint clean (other than harmless 
warning about dangling ../common symlink).

tested local built rpm, app launches/runs ok.


Consider 1-4, and I'll approve this.
Comment 4 Rex Dieter 2008-01-18 16:16:54 EST
submitted scratch build (w/ items 3,4 fixed) for giggles:
http://koji.fedoraproject.org/koji/taskinfo?taskID=357919
Comment 6 Rex Dieter 2008-01-20 16:17:53 EST
Close enough, APPROVED.

1 small thing (I'll leave it to you to address before building anything) 
regarding d-f-i usage, you used:
--vendor="fedora" ... --dir $RPM_BUILD_ROOT%{_datadir}/applications/kde
in effect having 2 vendors (fedora prefix + kde dir prefix), I'd suggest using
--vendor="" ... --dir $RPM_BUILD_ROOT%{_datadir}/applications/kde
instead.
Comment 7 Tom "spot" Callaway 2008-01-20 17:00:48 EST
New Package CVS Request
=======================
Package Name: kscope
Short Description: KDE front-end to Cscope
Owners: spot
Branches: F-7 F-8 EL-4 EL-5 
InitialCC: 
Cvsextras Commits: yes
Comment 8 Rex Dieter 2008-01-20 17:06:58 EST
noting the request for epel branches: only fedora kde packages include Provides
for kdelibs3/kdebase3, for rhel, you'll need kdelibs/kdebase, respectively.
Comment 9 Tom "spot" Callaway 2008-01-20 17:08:12 EST
Good to know, thanks. 

cvs done.
Comment 10 Tom "spot" Callaway 2008-01-20 17:20:32 EST
Builds away, thanks for the quick review.

Note You need to log in before you can comment on or make changes to this bug.