Bug 429414
| Summary: | Review Request: scapy - Interactive packet manipulation tool and network scanner | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Devan Goodwin <dgoodwin> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-01-23 14:11:40 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Devan Goodwin
2008-01-19 16:06:00 UTC
1)I don't think you should include changelog.txt. Remove it from installing. 2) Because of python dependency missing on rpm-build command, following error occurred in build.log. So for current scenario, good to add python as BR. /usr/lib/rpm/pythondeps.sh: line 8: python: command not found Spec URL: http://dgoodwin.fedorapeople.org/scapy.spec SRPM URL: http://dgoodwin.fedorapeople.org/scapy-1.1.1-2.fc8.src.rpm Added to spec file: BuildRequires: python >= 2.3 Removed changelog.txt: (root@kramer)[~dev/rpmbuild/RPMS/noarch] # ls /usr/share/doc/scapy-1.1.1/ AUTHORS changelog COPYING README (root@kramer)[~dev/rpmbuild/RPMS/noarch] # you need to either use macros or not. e.g. for install you used %{__install} but
same is not valid for rm. also don't mix style of macros
see
http://fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f5600ef3fc836f2e317badf
Spec URL: http://dgoodwin.fedorapeople.org/scapy.spec SRPM URL: http://dgoodwin.fedorapeople.org/scapy-1.1.1-3.fc8.src.rpm Replaced usage of $RPM_BUILD_ROOT with %{buildroot}. any reason for not using macro for rm command?
you used %{__install} then you should also use %{__rm} which will look like then
%{__rm} -rf %{buildroot}
Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 8ac720a1bea4304797c713ef1ed063f1 scapy-1.1.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. SHOULD: take care of above comment while importing this package in CVS. APPROVED. New Package CVS Request ======================= Package Name: scapy Short Description: Interactive packet manipulation tool and network scanner Owners: dgoodwin Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes cvs done. Imported into cvs, built successfully and pushed to F-7 and F-8. Closing as NEXTRELEASE. Package Change Request ====================== Package Name: scapy New Branches: EL-5 EL-6 Owners: dgoodwin tjikkun Git done (by process-git-requests). |