Spec URL: http://dgoodwin.fedorapeople.org/scapy.spec SRPM URL: http://dgoodwin.fedorapeople.org/scapy-1.1.1-1.fc8.src.rpm Description: Scapy is a powerful interactive packet manipulation program built on top of the Python interpreter. It can be used to forge or decode packets of a wide number of protocols, send them over the wire, capture them, match requests and replies, and much more. rpmlint output: (dev@kramer)[~/rpmbuild] % rpmlint SRPMS/scapy-1.1.1-1.fc8.src.rpm (dev@kramer)[~/rpmbuild] % rpmlint RPMS/noarch/scapy-1.1.1-1.fc8.noarch.rpm scapy.noarch: W: file-not-utf8 /usr/share/doc/scapy-1.1.1/changelog.txt (dev@kramer)[~/rpmbuild] %
1)I don't think you should include changelog.txt. Remove it from installing. 2) Because of python dependency missing on rpm-build command, following error occurred in build.log. So for current scenario, good to add python as BR. /usr/lib/rpm/pythondeps.sh: line 8: python: command not found
Spec URL: http://dgoodwin.fedorapeople.org/scapy.spec SRPM URL: http://dgoodwin.fedorapeople.org/scapy-1.1.1-2.fc8.src.rpm Added to spec file: BuildRequires: python >= 2.3 Removed changelog.txt: (root@kramer)[~dev/rpmbuild/RPMS/noarch] # ls /usr/share/doc/scapy-1.1.1/ AUTHORS changelog COPYING README (root@kramer)[~dev/rpmbuild/RPMS/noarch] #
you need to either use macros or not. e.g. for install you used %{__install} but same is not valid for rm. also don't mix style of macros see http://fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f5600ef3fc836f2e317badf
Spec URL: http://dgoodwin.fedorapeople.org/scapy.spec SRPM URL: http://dgoodwin.fedorapeople.org/scapy-1.1.1-3.fc8.src.rpm Replaced usage of $RPM_BUILD_ROOT with %{buildroot}.
any reason for not using macro for rm command? you used %{__install} then you should also use %{__rm} which will look like then %{__rm} -rf %{buildroot}
Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 8ac720a1bea4304797c713ef1ed063f1 scapy-1.1.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. SHOULD: take care of above comment while importing this package in CVS. APPROVED.
New Package CVS Request ======================= Package Name: scapy Short Description: Interactive packet manipulation tool and network scanner Owners: dgoodwin Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes
cvs done.
Imported into cvs, built successfully and pushed to F-7 and F-8. Closing as NEXTRELEASE.
Package Change Request ====================== Package Name: scapy New Branches: EL-5 EL-6 Owners: dgoodwin tjikkun
Git done (by process-git-requests).