Bug 429496 (stun-review)
| Summary: | Review Request: stun - Implements the stun protocol | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Huzaifa S. Sidhpurwala <huzaifas> |
| Component: | Package Review | Assignee: | Marek Mahut <mmahut> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, itamar, lemenkov, notting |
| Target Milestone: | --- | Flags: | mmahut:
fedora-review+
huzaifas: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-12-26 07:00:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Huzaifa S. Sidhpurwala
2008-01-21 05:33:51 UTC
Added correct macros to the spec. Awaiting upstream to identify the correct license under which the code is released. removing myself from review. Package is not building for all archs. Hey Huzaifa!
- I don't like much download_name macro, I would use something like %{name}d and
_%{version}__Aug13.tgz, but it's up to you :)
- I would also separate -server to a subpackage
- Use -p and -m with install
- Change the license to Vovida Software License 1.0 (btw, this is Fedora/FSF
compatible)
- Does not build with gcc 4.3, you will have to patch it
(http://koji.fedoraproject.org/koji/taskinfo?taskID=536657)
Hi Marek, Thanks for the reveiw, here are the improved files: SPEC: http://huzaifas.fedorapeople.org/spec/stun.spec SRPM: http://huzaifas.fedorapeople.org/srpms/stun-0.96-2.fc8.src.rpm Koji Builds: http://koji.fedoraproject.org/koji/taskinfo?taskID=559189 http://koji.fedoraproject.org/koji/taskinfo?taskID=559194 ping I see only minor issues: * please rename the patch to stun-0.96-whatthepatchdoes.patch * use -p at install to preserve the timestemps * the server package does not contain the RFC file after these minor issues are fixed, this package is approved. Typo. Fields %description for main package and server-subpackage are equal. Ping. So this package is approved long time ago, then where is cvs-request? New Package CVS Request ======================= Package Name: stun Short Description: Implements the stun protocol Owners: huzaifas Branches: F-9 EL-5 cvs done Why this package still not imported and built? Seems that someone forget about something :) Huzaifa, ping! Can I co-maintain it ? stun-0.96-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/stun-0.96-2.fc10 stun-0.96-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/stun-0.96-2.fc9 stun-0.96-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. stun-0.96-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |