Bug 429496 (stun-review) - Review Request: stun - Implements the stun protocol
Summary: Review Request: stun - Implements the stun protocol
Alias: stun-review
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Marek Mahut
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2008-01-21 05:33 UTC by Huzaifa S. Sidhpurwala
Modified: 2008-12-30 23:43 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2008-12-26 07:00:02 UTC
Type: ---
mmahut: fedora-review+
huzaifas: fedora-cvs+

Attachments (Terms of Use)

Description Huzaifa S. Sidhpurwala 2008-01-21 05:33:51 UTC
Spec URL: http://fedorapeople.org/~huzaifas/spec/stun.spec
SRPM URL: http://fedorapeople.org/~huzaifas/srpms/stun-0.96-0.fc8.src.rpm
Description: Implements a simple STUN server and client on Windows, Linux, and Solaris. The STUN protocol (Simple Traversal of UDP through NATs) is described in the IETF RFC 3489, available at http://www.ietf.org/rfc/rfc3489.txt

Comment 1 Huzaifa S. Sidhpurwala 2008-01-21 05:51:17 UTC
Added correct macros to the spec.
Awaiting upstream to identify the correct license under which the code is released.

Comment 2 Parag AN(पराग) 2008-03-07 13:22:49 UTC
removing myself from review.
Package is not building for all archs.

Comment 3 Marek Mahut 2008-03-28 19:47:16 UTC
Hey Huzaifa!

- I don't like much download_name macro, I would use something like %{name}d and
_%{version}__Aug13.tgz, but it's up to you :)

- I would also separate -server to a subpackage

- Use -p and -m with install

- Change the license to Vovida Software License 1.0 (btw, this is Fedora/FSF

- Does not build with gcc 4.3, you will have to patch it

Comment 5 Huzaifa S. Sidhpurwala 2008-04-14 06:11:36 UTC

Comment 6 Marek Mahut 2008-04-23 09:26:43 UTC
I see only minor issues:

 * please rename the patch to stun-0.96-whatthepatchdoes.patch
 * use -p at install to preserve the timestemps
 * the server package does not contain the RFC file

after these minor issues are fixed, this package is approved.

Comment 7 Peter Lemenkov 2008-07-03 18:28:48 UTC
Typo. Fields %description for main package and server-subpackage are equal.

Comment 8 Peter Lemenkov 2008-09-29 06:06:30 UTC
So this package is approved long time ago, then where is cvs-request?

Comment 9 Huzaifa S. Sidhpurwala 2008-09-29 06:13:48 UTC
New Package CVS Request
Package Name: stun
Short Description: Implements the stun protocol
Owners: huzaifas
Branches: F-9 EL-5

Comment 10 Huzaifa S. Sidhpurwala 2008-09-30 04:32:57 UTC
cvs done

Comment 11 Peter Lemenkov 2008-12-09 14:34:21 UTC
Why this package still not imported and built? Seems that someone forget about something :)

Comment 12 Marek Mahut 2008-12-19 20:44:22 UTC
Huzaifa, ping!

Comment 13 Itamar Reis Peixoto 2008-12-19 23:43:24 UTC
Can I co-maintain it ?

Comment 14 Fedora Update System 2008-12-24 19:56:24 UTC
stun-0.96-2.fc10 has been submitted as an update for Fedora 10.

Comment 15 Fedora Update System 2008-12-24 19:57:28 UTC
stun-0.96-2.fc9 has been submitted as an update for Fedora 9.

Comment 16 Fedora Update System 2008-12-30 23:40:56 UTC
stun-0.96-2.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2008-12-30 23:43:04 UTC
stun-0.96-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.