Bug 430940
| Summary: | [RHEL5 U2] Kernel-xen reports "failed to set up cpufreq notifier" while booting on some systems | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Jeff Burke <jburke> |
| Component: | kernel-xen | Assignee: | Bhavna Sarathy <bnagendr> |
| Status: | CLOSED ERRATA | QA Contact: | Martin Jenner <mjenner> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 5.2 | CC: | bburns, dzickus, frank.arnold, rdoty, xen-maint |
| Target Milestone: | rc | Keywords: | Regression |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://rhts.lab.boston.redhat.com/testlogs/14549/51244/416574/boot.kernel-xen-2.6.18-76.el5 | ||
| Whiteboard: | |||
| Fixed In Version: | RHBA-2008-0314 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-05-21 15:08:26 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 253746 | ||
|
Description
Jeff Burke
2008-01-30 18:40:28 UTC
This bugzilla has Keywords: Regression. Since no regressions are allowed between releases, it is also being proposed as a blocker for this release. Please resolve ASAP. This is the function that fails:
static int __init cpufreq_time_setup(void)
{
>>>>>>> if (!cpufreq_register_notifier(&time_cpufreq_notifier_block,
CPUFREQ_TRANSITION_NOTIFIER)) {
printk(KERN_ERR "failed to set up cpufreq notifier\n");
return -ENODEV;
}
return 0;
}
cpufreq_register_notifier will return 0 on success, which means this logic seems
reversed. I assume removing the '!' will fix the issue.
Does this fail on all systems or just a few? If the logic is reversed it should fail on all systems. I didn't think I saw the issue on Anaheim Barcelona system, but I'll check again. RHTS shows every xen system on x86 arch fails. Yes, I see the error with -80 and the logic is incorrect. This function must have been introduced recently as I have some Xen test kernels where this wasn't an issue. This function came as is with Rik's changes to cpufreq on xen. I put this patch in back in middle of December in -62.el5. So it should have been broken since then. Fixed Rik's broken patch; patch posted on Feb 12 to RHML and virt-list Based on comment 8, shouldn't this be a high or urgent priority? Sure. Russ, could you please add this to the AMD tracker, so I can keep this in my radar? in kernel-$NEW_VER You can download this test kernel from http://people.redhat.com/dzickus/el5 in kernel-2.6.18-85.el5 You can download this test kernel from http://people.redhat.com/dzickus/el5 We saw this with Beta. All of our systems with snap3 or snap4 installs don't show this anymore. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2008-0314.html |