Bug 431356
| Summary: | Review Request: dvipng - Converts DVI files to PNG/GIF format | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jonathan Underwood <jonathan.underwood> |
| Component: | Package Review | Assignee: | Patrice Dumas <pertusus> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, jnovy, notting, pertusus |
| Target Milestone: | --- | Flags: | pertusus:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-02-05 01:27:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jonathan Underwood
2008-02-03 14:22:39 UTC
Spec URL: http://jgu.fedorapeople.org/dvipng.spec SRPM URL: http://jgu.fedorapeople.org/dvipng-1.9-2.fc9.src.rpm * Sun Feb 3 2007 Jonathan G. Underwood <jonathan.underwood> - 1.9-2 - Install dvigif info file - Add Provides for dvigif The release should be at least 16+1 since 16 is the current dvipng
from texlive release.
there is no dvigif info manual.
I don't think the Provides for dvigif is useful.
The kpathsea requires is also certainly unneeded since it should
be automatically detected.
I suggest using
make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p'
to keep the man page timestamp.
To keep the changelogs timestamp, you can use
iconv -f ISO-8859-1 -t UTF8 $i > $i.utf8 && touch -r $i $i.utf8 && mv $i.utf8 $i
I suggest removing the .gz from the file names in the install-info
scriptlets, install-info does it automatically.
I also suggest using globs for man pages and info files, like
%{_infodir}/dvipng.info*
%{_mandir}/man1/dvigif.1*
%{_mandir}/man1/dvipng.1*
The license of the doc seems to be the OFSFDL.
Spec URL: http://jgu.fedorapeople.org/dvipng.spec SRPM URL: http://jgu.fedorapeople.org/dvipng-1.9-50.fc9.src.rpm * Sun Feb 3 2007 Jonathan G. Underwood <jonathan.underwood> - 1.9-50 - Remove kpathsea Requires - Add OFSFDL license tag - Make INSTALL use install -p - Preserve time stamp of ChangeLog and ChangeLog.0 files - Use globbing in filelist - Remove .gz from the end of filenames in install-info commands - Bump release to 50 to fix up upgrade path from current dvipng package from texlive * rpmlint is silent * follow packaging guidelines * free software * works as intended * match upstream: 9107065e4da9a18dfff2c1a76fbbf919 dvipng-1.9.tar.gz * %files section right APPROVED Splendid, cheers Patrice. Can I put you as a co-maintainer? Jindrich - same question to you - are you willing to be a co-maintainer? Yes, you can. New Package CVS Request ======================= Package Name: dvipng Short Description: Converts DVI files to PNG/GIF format Owners: jgu,pertusus,jnovy Branches: InitialCC: Cvsextras Commits: Yes Jindrich - have added you as a co-maintainer, but if you'd rather not be, it's trivial to change it. cvs done. Thanks Kevin. Thanks Patrice. Package imported and built. Jonathan, thanks for adding me as comaintainer. I returned from vacations yesterday, so I couldn't take action sooner. Hi Jindrich - no problem. Hope you had a good vacation. |