Bug 431356 - Review Request: dvipng - Converts DVI files to PNG/GIF format
Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Patrice Dumas
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-02-03 14:22 UTC by Jonathan Underwood
Modified: 2008-02-14 10:02 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-02-05 01:27:05 UTC
Type: ---
Embargoed:
pertusus: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Jonathan Underwood 2008-02-03 14:22:39 UTC
Spec URL: http://jgu.fedorapeople.org/dvipng.spec
SRPM URL: http://jgu.fedorapeople.org/dvipng-1.9-1.fc9.src.rpm
Description: 
This program makes PNG and/or GIF graphics from DVI files as obtained
from TeX and its relatives.

It is intended to produce anti-aliased screen-resolution images as
fast as is possible. The target audience is people who need to generate
and regenerate many images again and again. 

Commentary:
Patrice Dumas recently made a call for packages to split out components of texlive for which texlive is not upstream. This is one such package.

Comment 1 Jonathan Underwood 2008-02-03 14:34:00 UTC
Spec URL: http://jgu.fedorapeople.org/dvipng.spec
SRPM URL: http://jgu.fedorapeople.org/dvipng-1.9-2.fc9.src.rpm

* Sun Feb  3 2007 Jonathan G. Underwood <jonathan.underwood> - 1.9-2
- Install dvigif info file
- Add Provides for dvigif


Comment 2 Patrice Dumas 2008-02-03 20:02:44 UTC
The release should be at least 16+1 since 16 is the current dvipng 
from texlive release.

there is no dvigif info manual.

I don't think the Provides for dvigif is useful.

The kpathsea requires is also certainly unneeded since it should 
be automatically detected.

I suggest using 
make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p'
to keep the man page timestamp.

To keep the changelogs timestamp, you can use
    iconv -f ISO-8859-1 -t UTF8 $i > $i.utf8 && touch -r $i $i.utf8 && mv $i.utf8 $i

I suggest removing the .gz from the file names in the install-info
scriptlets, install-info does it automatically.

I also suggest using globs for man pages and info files, like
%{_infodir}/dvipng.info*
%{_mandir}/man1/dvigif.1*
%{_mandir}/man1/dvipng.1*

The license of the doc seems to be the OFSFDL.

Comment 3 Jonathan Underwood 2008-02-03 21:54:12 UTC
Spec URL: http://jgu.fedorapeople.org/dvipng.spec
SRPM URL: http://jgu.fedorapeople.org/dvipng-1.9-50.fc9.src.rpm

* Sun Feb  3 2007 Jonathan G. Underwood <jonathan.underwood> - 1.9-50
- Remove kpathsea Requires
- Add OFSFDL license tag
- Make INSTALL use install -p
- Preserve time stamp of ChangeLog and ChangeLog.0 files
- Use globbing in filelist
- Remove .gz from the end of filenames in install-info commands
- Bump release to 50 to fix up upgrade path from current dvipng package from texlive


Comment 4 Patrice Dumas 2008-02-03 23:08:29 UTC
* rpmlint is silent
* follow packaging guidelines
* free software
* works as intended
* match upstream:
9107065e4da9a18dfff2c1a76fbbf919  dvipng-1.9.tar.gz
* %files section right

APPROVED

Comment 5 Jonathan Underwood 2008-02-03 23:17:45 UTC
Splendid, cheers Patrice. Can I put you as a co-maintainer?

Jindrich - same question to you - are you willing to be a co-maintainer?

Comment 6 Patrice Dumas 2008-02-03 23:30:20 UTC
Yes, you can.

Comment 7 Jonathan Underwood 2008-02-04 01:42:20 UTC
New Package CVS Request
=======================
Package Name: dvipng
Short Description: Converts DVI files to PNG/GIF format
Owners: jgu,pertusus,jnovy
Branches: 
InitialCC: 
Cvsextras Commits: Yes

Comment 8 Jonathan Underwood 2008-02-04 01:43:11 UTC
Jindrich - have added you as a co-maintainer, but if you'd rather not be, it's
trivial to change it.

Comment 9 Kevin Fenzi 2008-02-04 19:41:26 UTC
cvs done.

Comment 10 Jonathan Underwood 2008-02-05 01:27:05 UTC
Thanks Kevin. Thanks Patrice.

Package imported and built.

Comment 11 Jindrich Novy 2008-02-14 05:18:10 UTC
Jonathan, thanks for adding me as comaintainer. I returned from vacations
yesterday, so I couldn't take action sooner.

Comment 12 Jonathan Underwood 2008-02-14 10:02:55 UTC
Hi Jindrich - no problem. Hope you had a good vacation.


Note You need to log in before you can comment on or make changes to this bug.