Bug 431368

Summary: Review Request: inconsoleata-fonts - A monospace font, designed for code listings and the like, in print
Product: [Fedora] Fedora Reporter: Kevin Fenzi <kevin>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, fonts-bugs, notting
Target Milestone: ---Flags: panemade: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-02-13 17:18:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 486269    

Description Kevin Fenzi 2008-02-03 17:35:36 UTC
Spec URL: http://www.scrye.com/~kevin/fedora/inconsoleata-fonts/inconsolata-fonts.spec
SRPM URL: http://www.scrye.com/~kevin/fedora/inconsoleata-fonts/inconsolata-fonts-1.009-1.fc9.src.rpm
Description: 

A monospace font, designed for code listings and the like, in print

Comment 1 Parag AN(पराग) 2008-02-04 06:55:20 UTC
Review:
+ package builds in mock.
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
378f8830bc66804d5fe2e7338598e654  Inconsolata.sfd
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
  strings  Inconsolata.sfd | grep OFL
Copyright: Created by Raph Levien using his own tools and FontForge. Copyright
2006 Raph Levien. Released under the SIL Open Font License,
http://scripts.sil.org/OFL.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ followed fonts packaging guidelines.

APPROVED.

Comment 2 Kevin Fenzi 2008-02-04 19:31:46 UTC
Thanks for the speedy review!

New Package CVS Request
=======================
Package Name: inconsolata-fonts
Short Description: A monospace font, designed for code listings and the like, in
print
Owners: kevin
Branches: F-8
InitialCC: 
Cvsextras Commits: yes




Comment 3 Kevin Fenzi 2008-02-04 19:51:12 UTC
cvs done.

Comment 4 Parag AN(पराग) 2008-02-13 05:54:26 UTC
Is this built?

Comment 5 Kevin Fenzi 2008-02-13 17:18:01 UTC
Yes indeed. Done and pushed. 
Closing.