Red Hat Bugzilla – Bug 486269
Review Request: levien-inconsolata-fonts - Inconsolata fonts
Last modified: 2012-07-13 21:57:23 EDT
Spec URL: http://www.scrye.com/~kevin/fedora/levien-inconsolata-fonts/levien-inconsolata-fonts.spec SRPM URL: http://www.scrye.com/~kevin/fedora/levien-inconsolata-fonts/levien-inconsolata-fonts-1.01-1.fc11.src.rpm Description: A monospace font, designed for code listings and the like, in print. This is a rename/update of the existing inconsolata-fonts package.
http://fedoraproject.org/wiki/Shipping_fonts_in_Fedora_%28FAQ%29#What_if_the_new_naming_guidelines_require_me_to_rename_my_source_package.3F
1. a fontconfig ruleset would be nice http://fedoraproject.org/wiki/Shipping_fonts_in_Fedora_%28FAQ%29#The_fontconfig_stuff_the_font_guidelines_suggest_seems_complex._Can_I_skip_it.3F 2. FPC will want you to use %global not %define soonish http://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define 3. Are you sure you want to provide the old name? http://fedoraproject.org/wiki/Shipping_fonts_in_Fedora_%28FAQ%29#Do_I_need_to_Provide_my_old_package_names.3F Anyway, nothing here is blocking ☎☎☎ APPROVED ☎☎☎ Please do not forget the other steps in http://fedoraproject.org/wiki/Shipping_fonts_in_Fedora_%28FAQ%29#What_if_the_new_naming_guidelines_require_me_to_rename_my_source_package.3F
I've made those changes here: http://www.scrye.com/~kevin/fedora/levien-inconsolata-fonts/levien-inconsolata-fonts-1.01-2.fc11.src.rpm However, it's not building here under mock. I can't seem to track down why. ;( Will keep looking, but if anyone has any ideas, let me know...
The package renaming changes %{fontname} and a define was changed to global. Maybe there's a conflict with your use of $fontname in the fontforge script? Otherwise, can you post failing build logs?
Yeah, the old font fails exactly the same way, so it must be a change somewhere in rawhide. ;( http://koji.fedoraproject.org/koji/getfile?taskID=1167442&name=build.log + fontforge -script - /builddir/build/SOURCES/Inconsolata.sfd Copyright (c) 2000-2008 by George Williams. Executable based on sources from 16:11 GMT 24-Dec-2008. Library based on sources from 16:11 GMT 24-Dec-2008. File "<stdin>", line 2 while ( i < $argc ) ^ SyntaxError: invalid syntax error: Bad exit status from /var/tmp/rpm-tmp.e4UUpX (%build) any ideas?
It was enabling the python bindings. When those are enabled, it assumes python... passing it '-lang=ff' causes it to use the 'legacy' fontforge scripting lang. Will get this imported and built now. Does the fontconfig file I have here look ok? New Package CVS Request ======================= Package Name: levien-inconsolata-fonts Short Description: A monospace font, designed for code listings and the like, in print Owners: kevin Branches: devel InitialCC:
cvs done.
Built in rawhide and old package marked dead.
Going ahead with a EL6 branch Package Change Request ====================== Package Name: levien-inconsolata-fonts New Branches: el6 Owners: kevin InitialCC: