Bug 431707

Summary:	Review Request: sugar-toolkit - Sugar toolkit
Product:	[Fedora] Fedora	Reporter:	Marco Pesenti Gritti <mpg>
Component:	Package Review	Assignee:	Tomeu Vizoso <tomeu>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	bdpepple, fedora-package-review, kevin, mail, notting, pbrobinson
Target Milestone:	---	Flags:	tomeu: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-08-12 00:11:53 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	462625

Description Marco Pesenti Gritti 2008-02-06 16:32:56 UTC

Spec URL: http://dev.laptop.org/~marco/sugar-toolkit.spec
SRPM URL: http://dev.laptop.org/~marco/sugar-toolkit-0.79.0-1.fc8.src.rpm
Description: Sugar is the core of the OLPC Human Interface. The toolkit provides
a set of widgets to build HIG compliant applications and interfaces
to interact with system services like presence and the datastore.

Comment 1 Tomeu Vizoso 2008-02-07 14:32:48 UTC

rpmlint is silent.

The checkout instructions contain a typo:

- # cd sugartoolkit
+ # cd sugar-toolkit

The checkout instructions doesn't tell how to create the tarball contained in
the SRPM.

Source0 doesn't point to an existing tarball.

The rest looks good.

Comment 2 Kevin Fenzi 2008-02-07 19:28:23 UTC

Did you mean to reject this package? fedora-review: - is usually reserved for
packages that can never meet the Fedora guidelines, ie they have a License issue
or the like. 

Set fedora-review: ? and assign this bug to yourself if you intend to review it.

Comment 3 Tomeu Vizoso 2008-02-07 19:40:53 UTC

oops, Kevin is right. I misunderstood the review process.

Comment 4 Marco Pesenti Gritti 2008-02-08 14:34:50 UTC

I made Source0 point to an actual tarball which should address all your points
(checkout instructions are no more necessary).

http://dev.laptop.org/~marco/sugar-toolkit.spec
http://dev.laptop.org/~marco/sugar-toolkit-0.79.0-2.fc8.src.rpm

Comment 5 Tomeu Vizoso 2008-02-08 17:48:04 UTC

Agreed.

Source0 has a type, though. Should be 'sources', not 'source'.

Please fix before importing to CVS.

Comment 6 Marco Pesenti Gritti 2008-02-08 18:15:30 UTC

New Package CVS Request
=======================
Package Name: sugar-toolkit
Short Description: Sugar toolkit
Owners: mpg
Branches: F-8 OLPC-2
InitialCC: mpg
Cvsextras Commits: yes

Comment 7 Dennis Gilmore 2008-02-08 18:20:44 UTC

cvs done

Comment 8 Brian Pepple 2008-05-25 20:46:17 UTC

Marco, has this been built?  If so, this bug can be closed.

Comment 9 Brian Pepple 2008-08-12 00:11:53 UTC

Closing, since this has been imported into cvs & built.

Comment 10 Marco Pesenti Gritti 2008-11-03 17:15:58 UTC

Package Change Request
======================
Package Name: sugar-toolkit
New Branches: F-11

Comment 11 Marco Pesenti Gritti 2008-11-03 17:58:47 UTC

Package Change Request
======================
Package Name: sugar-toolkit
New Branches: F-10

Comment 12 Dennis Gilmore 2008-11-03 19:08:30 UTC

CVS Done

Comment 13 Tomeu Vizoso 2008-11-12 11:04:32 UTC

Package Change Request
======================
Package Name: sugar-toolkit
New Branches: OLPC-4
Owners: mpg erikos tomeu

Comment 14 Kevin Fenzi 2008-11-12 16:52:14 UTC

cvs done.

Comment 15 Peter Robinson 2010-06-10 20:51:05 UTC

Package Change Request
======================
Package Name: sugar-toolkit
New Branches: EL-6
Owners: pbrobinson sdz

Comment 16 Kevin Fenzi 2010-06-11 04:33:43 UTC

cvs done.