Spec URL: http://dev.laptop.org/~marco/sugar-toolkit.spec SRPM URL: http://dev.laptop.org/~marco/sugar-toolkit-0.79.0-1.fc8.src.rpm Description: Sugar is the core of the OLPC Human Interface. The toolkit provides a set of widgets to build HIG compliant applications and interfaces to interact with system services like presence and the datastore.
rpmlint is silent. The checkout instructions contain a typo: - # cd sugartoolkit + # cd sugar-toolkit The checkout instructions doesn't tell how to create the tarball contained in the SRPM. Source0 doesn't point to an existing tarball. The rest looks good.
Did you mean to reject this package? fedora-review: - is usually reserved for packages that can never meet the Fedora guidelines, ie they have a License issue or the like. Set fedora-review: ? and assign this bug to yourself if you intend to review it.
oops, Kevin is right. I misunderstood the review process.
I made Source0 point to an actual tarball which should address all your points (checkout instructions are no more necessary). http://dev.laptop.org/~marco/sugar-toolkit.spec http://dev.laptop.org/~marco/sugar-toolkit-0.79.0-2.fc8.src.rpm
Agreed. Source0 has a type, though. Should be 'sources', not 'source'. Please fix before importing to CVS.
New Package CVS Request ======================= Package Name: sugar-toolkit Short Description: Sugar toolkit Owners: mpg Branches: F-8 OLPC-2 InitialCC: mpg Cvsextras Commits: yes
cvs done
Marco, has this been built? If so, this bug can be closed.
Closing, since this has been imported into cvs & built.
Package Change Request ====================== Package Name: sugar-toolkit New Branches: F-11
Package Change Request ====================== Package Name: sugar-toolkit New Branches: F-10
CVS Done
Package Change Request ====================== Package Name: sugar-toolkit New Branches: OLPC-4 Owners: mpg erikos tomeu
cvs done.
Package Change Request ====================== Package Name: sugar-toolkit New Branches: EL-6 Owners: pbrobinson sdz