Bug 431868
Summary: | mounting CIFS subshare doesn't autoconvert prepath delimiters | ||||||
---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Linux 5 | Reporter: | Jeff Layton <jlayton> | ||||
Component: | kernel | Assignee: | Jeff Layton <jlayton> | ||||
Status: | CLOSED ERRATA | QA Contact: | Martin Jenner <mjenner> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | 5.1 | CC: | coughlan, dmair, donald.teed, dzickus, jlayton, jplans, mkoci, riek, ssorce, staubach, steved | ||||
Target Milestone: | rc | Keywords: | Reopened | ||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2009-01-20 20:14:16 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | 370501 | ||||||
Bug Blocks: | 447569 | ||||||
Attachments: |
|
Comment 1
Jeff Layton
2008-02-07 15:23:57 UTC
This bugzilla has Keywords: Regression. Since no regressions are allowed between releases, it is also being proposed as a blocker for this release. Please resolve ASAP. Note that this regression is actually caused by a userspace mount.cifs patch. While the userspace patch fixes the situation where we're mounting a subshare of a mount without posix extensions, it breaks this when posix extensions are enabled. We have 2 choices -- pull the patch from samba for 5.2 and leave non-posix mounts in a broken state, or try to fix this in kernel. I think fixing this in kernel is probably the best solution, but if there are time constraints we can go with the first option. The fix shouldn't be terribly difficult. I'll hopefully have a patch later today. Created attachment 294220 [details]
patch -- add routine to convert delimiters on the fly
This patch seems to fix it. There may be cleaner ways to do this using some of
the string handling routines built into the kernel though. I want to do a bit
more testing on this and make sure we're not breaking any other cases. Once I
do I'll plan to email Steve French on this and see if he can review it quickly
for us.
If so, it would be good to get this into a 5.2 respin (if there is one).
Patch sent to upstream list and Steve F. Awaiting his response... This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. We've decided to pull the problem patch from Samba for 5.2 and focus on getting this fixed the right way upstream. That probably won't happen until 5.3 though, so resetting this for 5.3. Development Management has reviewed and declined this request. You may appeal this decision by reopening this request. The upstream patch ended up looking quite a bit different than what was originally proposed. I've also posted an updated userspace patch and an update to the manpage to the upstream lists today. This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. in kernel-2.6.18-113.el5 You can download this test kernel from http://people.redhat.com/dzickus/el5 *** Bug 446433 has been marked as a duplicate of this bug. *** An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2009-0225.html |