Bug 432137 (kcoloredit)
| Summary: | Review Request: kcoloredit - A color palette Editor for KDE 4 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sebastian Vahl <fedora> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, rdieter |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-02-13 10:51:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Sebastian Vahl
2008-02-09 00:49:15 UTC
I confused on Requires: oxygen-icon-theme. Can it be Reqires: hicolor-icon-theme? On my rawhide machine, When I rebuilt this srpm and installed rpm, I got
Preparing... ########################################### [100%]
file /usr/share/locale/ta/LC_MESSAGES/kcoloredit.mo from install of
kcoloredit-4.0.1-1.fc9.i386 conflicts with file from package
kde-i18n-Tamil-3.5.8-3.fc9.noarch
file /usr/share/locale/ja/LC_MESSAGES/kcoloredit.mo from install of
kcoloredit-4.0.1-1.fc9.i386 conflicts with file from package
kde-i18n-Japanese-3.5.8-3.fc9.noarch
file /usr/share/locale/pa/LC_MESSAGES/kcoloredit.mo from install of
kcoloredit-4.0.1-1.fc9.i386 conflicts with file from package
kde-i18n-Punjabi-3.5.8-3.fc9.noarch
file /usr/share/locale/zh_TW/LC_MESSAGES/kcoloredit.mo from install of
kcoloredit-4.0.1-1.fc9.i386 conflicts with file from package
kde-i18n-Chinese-Big5-3.5.8-3.fc9.noarch
file /usr/share/locale/zh_CN/LC_MESSAGES/kcoloredit.mo from install of
kcoloredit-4.0.1-1.fc9.i386 conflicts with file from package
kde-i18n-Chinese-3.5.8-3.fc9.noarch
Just found that repoquery --whatprovides oxygen-icon-theme kdebase-runtime-0:4.0.1-1.fc9.i386 These conflicting files will be removed from kde-i18n ASAP. (We want to ship the version from the current kcoloredit, not the KDE 3 one.) As for oxygen-icon-theme, it's needed (it's the only theme to provide some of the used icons, and also the global fallback in KDE 4, and also what we're defaulting to), and as you've noticed, it's currently in kdebase-runtime anyway (it might get split out later). Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=405234 + rpmlint is silent for SRPM. Bur NOT for RPM. kcoloredit.i386: W: dangling-symlink /usr/share/doc/HTML/en/kcoloredit/common /usr/share/doc/HTML/en/common kcoloredit.i386: W: symlink-should-be-relative /usr/share/doc/HTML/en/kcoloredit/common /usr/share/doc/HTML/en/common ==> Ok to accept here + source files match upstream. 77f69d70f105f83713e427ae0c8f1e5b kcoloredit-4.0.1.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honored correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + xdg-utils scriptlets are used. + Desktop file installed correctly. + GUI app. APPROVED. File conflicts fixed in kde-i18n-3.5.8-5.fc9. (In reply to comment #6) > File conflicts fixed in kde-i18n-3.5.8-5.fc9. thanks. (In reply to comment #5) > APPROVED. Thanks! New Package CVS Request ======================= Package Name: kcoloredit Short Description: A color palette Editor for KDE 4 Owners: svahl,than,rdieter,kkofler,ltinkl Branches: InitialCC: Cvsextras Commits: no cvs done. Imported and built for rawhide: http://koji.fedoraproject.org/koji/buildinfo?buildID=35906 |