Bug 432343
| Summary: | e1000e: Wakeup-on-Lan does not work | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Flavio Leitner <fleitner> |
| Component: | kernel | Assignee: | Andy Gospodarek <agospoda> |
| Status: | CLOSED ERRATA | QA Contact: | Martin Jenner <mjenner> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 5.1 | CC: | akarlsso, peterm, tao |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | RHBA-2008-0314 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-05-21 15:09:12 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 246139 | ||
|
Description
Flavio Leitner
2008-02-11 13:59:56 UTC
I see the patch now:
commit 23b66e2bc2bcebacab7292d7731b7372065b3f98
Author: Auke Kok <auke-jan.h.kok>
Date: Mon Feb 11 09:25:51 2008 -0800
e1000e: Fix logic reversal keeping link active
A logic mishap caused the adapter to keep link while we can
disable it due to WoL not being active, and vice versa.
Signed-off-by: Auke Kok <auke-jan.h.kok>
Signed-off-by: Jeff Garzik <jeff>
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index f58f017..b9b0d32 100644
--- a/drivers/net/e1000e/netdev.c
+++ b/drivers/net/e1000e/netdev.c
@@ -2008,7 +2008,7 @@ static void e1000_power_down_phy(struct e1000_adapter
*adapter)
u16 mii_reg;
/* WoL is enabled */
- if (!adapter->wol)
+ if (adapter->wol)
return;
/* non-copper PHY? */
My test kernels have been updated to include a patch for this bugzilla. http://people.redhat.com/agospoda/#rhel5 Please test them and report back your results. This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. Hi there Andy, Yes, I have tested kernel-2.6.18-83.el5.gtest.43.x86_64.rpm from your people page, and I can confirm that a system that is shut down can be woken up with ether-wake. Thanks! /Anders This event sent from IssueTracker by akarlsso issue 139285 Anders, Could you check if with S3(Ram) and S4(Disk) the NIC is off too? thanks! Flavio I'm considering pushing this patch: http://people.redhat.com/agospoda/rhel5/e1000e-wol-fixes.patch for 5.2. Does anyone object? No objections from me, just a note that waking up from S4 still doesn't work and I think we should open another bz for it. Flavio in kernel-$NEW_VER You can download this test kernel from http://people.redhat.com/dzickus/el5 in kernel-2.6.18-85.el5 You can download this test kernel from http://people.redhat.com/dzickus/el5 An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2008-0314.html |