Bug 433190
Summary: | colorls.sh optimizations | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <ville.skytta> | ||||
Component: | coreutils | Assignee: | Ondrej Vasik <ovasik> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | low | Docs Contact: | |||||
Priority: | low | ||||||
Version: | rawhide | CC: | twaugh | ||||
Target Milestone: | --- | Keywords: | Patch | ||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2008-02-18 16:31:43 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Ville Skyttä
2008-02-17 10:26:26 UTC
Created attachment 295095 [details]
Optimize noninteractive shell case, reduce amount of stat calls
Thanks for optimizations. I used your patch with one change - aliases for non-colored ls are kept inside the [ -z "$LS_COLORS" ] - doesn't make sense to set them to non-colored and immediately to colored when LS_COLORS are set before colorls.sh run. Will keep .csh script as it is, as is used much less than .sh script. Built as coreutils-6.10-8.fc9 , closing RAWHIDE. Yep, your change looks good. When making the patch, in some of my intermediate versions of it there was a chance that the "ll" and "l." aliases wouldn't be set at all which is why I moved them to the top level, but that's clearly no longer needed. Thanks! |