Bug 433190 - colorls.sh optimizations
Summary: colorls.sh optimizations
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: coreutils
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Ondrej Vasik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-02-17 10:26 UTC by Ville Skyttä
Modified: 2008-02-18 17:20 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-02-18 16:31:43 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Optimize noninteractive shell case, reduce amount of stat calls (1.90 KB, patch)
2008-02-17 10:26 UTC, Ville Skyttä
no flags Details | Diff

Description Ville Skyttä 2008-02-17 10:26:26 UTC
Attached is a patch containing two optimizations for colorls.sh:

1) Don't do anything but set the "ll" and "l." aliases for noninteractive shells.
2) Avoid a bunch of stat calls whose results would just be thrown away.

The csh variant could seemingly use similar optimizations, but I'm not a csh
hacker so I'll leave it to someone else.

Comment 1 Ville Skyttä 2008-02-17 10:26:26 UTC
Created attachment 295095 [details]
Optimize noninteractive shell case, reduce amount of stat calls

Comment 2 Ondrej Vasik 2008-02-18 16:31:43 UTC
Thanks for optimizations. I used your patch with one change - aliases for
non-colored ls are kept inside the [ -z "$LS_COLORS" ] - doesn't make sense to
set them to non-colored and immediately to colored when LS_COLORS are set before
colorls.sh run. Will keep .csh script as it is, as is used much less than .sh
script. Built as coreutils-6.10-8.fc9 , closing RAWHIDE.


Comment 3 Ville Skyttä 2008-02-18 17:20:22 UTC
Yep, your change looks good.  When making the patch, in some of my intermediate
versions of it there was a chance that the "ll" and "l." aliases wouldn't be set
at all which is why I moved them to the top level, but that's clearly no longer
needed.  Thanks!


Note You need to log in before you can comment on or make changes to this bug.