Bug 434911
| Summary: | Review Request: gmfsk - A Gnome Multimode HF Terminal for Ham Radio | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert 'Bob' Jensen <bob> | ||||
| Component: | Package Review | Assignee: | Jeroen van Meeuwen <vanmeeuwen+fedora> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-package-review, notting, vanmeeuwen+fedora | ||||
| Target Milestone: | --- | Flags: | vanmeeuwen+fedora:
fedora-review+
kevin: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-03-02 22:07:50 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Robert 'Bob' Jensen
2008-02-26 07:10:19 UTC
RPM Lint: OK Package name: OK Spec file: OK License: OK Actual License: OK %doc License: OK Spec file language: OK Spec file readable: OK Upstream source vs. used tarball: OK (md5sum match) Compile and Build: - F-7: OK - F-8: OK - rawhide: FAILED (logs attached) - EL-5: FAILED (but not targeted anyway) Applicable Package Guidelines: - -debuginfo package: OK (~592K) Locales: OK Shared libs: N/A Relocatable: N/A Directory and file ownership: OK No duplicate files in %files: OK File Permissions: OK Macro usage: OK Code vs. Content: OK (Large) Documentation: OK %doc affecting runtime: OK Header files in -devel package: N/A Static Libraries in -static package: N/A pkgconfig Requires: N/A Library files: N/A Devel requires base package: N/A .la libtool archives: N/A Duplicate ownership of files/directories: OK Remove BuildRoot: OK UTF-8 filenames: OK Please examine the build log files attached Created attachment 295915 [details]
rawhide-i386-build-log
The release number in the spec file should be set to 1 too just to be "standard" rather than the multi-part "pre" version number like it is now. Release number is fine as it is now. Guidelines say you should append "pre", "alpha", "beta" and vcs snapshot tags to the release tag. New srpm: http://bjensen.fedorapeople.org/pkgs/hams/SRPMS/gmfsk-0.7-0.pre1.4.fc9.src.rpm New spec: http://bjensen.fedorapeople.org/pkgs/hams/SPECS/gmfsk.spec This fixes the build problem, and some errors during desktop file install. New Package CVS Request ======================= Package Name: gmfsk Short Description: A Gnome Multimode HF Terminal for Ham Radio Owners: bjensen,sconklin Branches: F-7 F-8 InitialCC: sindgepb Cvsextras Commits: yes Per the conversation on irc, do fix the versioning here before importing... cvs done. Fixed NVR New srpm: http://bjensen.fedorapeople.org/pkgs/hams/SRPMS/gmfsk-0.7-0.5.pre1.fc9.src.rpm New spec: http://bjensen.fedorapeople.org/pkgs/hams/SPECS/gmfsk.spec gmfsk-0.7-0.5.pre1.fc8 has been submitted as an update for Fedora 8 gmfsk-0.7-0.5.pre1.fc7 has been submitted as an update for Fedora 7 Thank you for the review and other help. gmfsk-0.7-0.5.pre1.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. gmfsk-0.7-0.5.pre1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. |