Red Hat Bugzilla – Bug 434911
Review Request: gmfsk - A Gnome Multimode HF Terminal for Ham Radio
Last modified: 2008-03-03 13:27:00 EST
Spec URL: http://bjensen.fedorapeople.org/pkgs/hams/SPECS/gmfsk.spec
SRPM URL: http://bjensen.fedorapeople.org/pkgs/hams/SRPMS/gmfsk-0.7-0.pre1.3.fc8.src.rpm
Description: gmfsk is a terminal program for amateur radio digital communication modes for GNOME. It supports MFSK, RTTY, THROB, PSK31, MT63 and Hellschreiber
modulations. It is used for keyboard-to-keyboard chatting and not reliable
This srpm mock builds on Fedora 7 and Fedora 8, all resulting rpms are rpmlint clean.
RPM Lint: OK
Package name: OK
Spec file: OK
Actual License: OK
%doc License: OK
Spec file language: OK
Spec file readable: OK
Upstream source vs. used tarball: OK (md5sum match)
Compile and Build:
- F-7: OK
- F-8: OK
- rawhide: FAILED (logs attached)
- EL-5: FAILED (but not targeted anyway)
Applicable Package Guidelines:
- -debuginfo package: OK (~592K)
Shared libs: N/A
Directory and file ownership: OK
No duplicate files in %files: OK
File Permissions: OK
Macro usage: OK
Code vs. Content: OK
(Large) Documentation: OK
%doc affecting runtime: OK
Header files in -devel package: N/A
Static Libraries in -static package: N/A
pkgconfig Requires: N/A
Library files: N/A
Devel requires base package: N/A
.la libtool archives: N/A
Duplicate ownership of files/directories: OK
Remove BuildRoot: OK
UTF-8 filenames: OK
Please examine the build log files attached
Created attachment 295915 [details]
The release number in the spec file should be set to 1 too just to be "standard"
rather than the multi-part "pre" version number like it is now.
Release number is fine as it is now. Guidelines say you should append "pre",
"alpha", "beta" and vcs snapshot tags to the release tag.
This fixes the build problem, and some errors during desktop file install.
New Package CVS Request
Package Name: gmfsk
Short Description: A Gnome Multimode HF Terminal for Ham Radio
Branches: F-7 F-8
Cvsextras Commits: yes
Per the conversation on irc, do fix the versioning here before importing...
gmfsk-0.7-0.5.pre1.fc8 has been submitted as an update for Fedora 8
gmfsk-0.7-0.5.pre1.fc7 has been submitted as an update for Fedora 7
Thank you for the review and other help.
gmfsk-0.7-0.5.pre1.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.
gmfsk-0.7-0.5.pre1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.