Bug 435398
| Summary: | $name[selector]:it should fail when any number of 'selector' is out of range | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Cai Xianchao <caixianchao> | ||||
| Component: | tcsh | Assignee: | Vitezslav Crhonek <vcrhonek> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Bill Huang <bhuang> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 5.1 | CC: | azelinka, cward, jbwells, joshua.bakerlepain, k.georgiou, psplicha, s.hart | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | i686 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 495642 515474 (view as bug list) | Environment: | |||||
| Last Closed: | 2009-01-20 20:33:22 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 495642, 515474 | ||||||
| Attachments: |
|
||||||
|
Description
Cai Xianchao
2008-02-29 01:37:37 UTC
Created attachment 296297 [details]
This is a patch fixing the bug.
Thanks for report and patch! Fixed in Fedora rawhide. This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2009-0060.html This patch effectively breaks expected functionality in tcsh. Running the following script produces "argv: Subscript out of range." #!/bin/tcsh -f echo $argv[1-] In the tcsh manual : http://www.tcsh.org/tcsh.html/Variable_substitution.html $name[selector] ${name[selector]} Substitutes only the selected words from the value of name. The selector is subjected to `$' substitution and may consist of a single number or two numbers separated by a `-'. The first word of a variable's value is numbered `1'. If the first number of a range is omitted it defaults to `1'. If the last member of a range is omitted it defaults to `$#name'. The selector `*' selects all words. It is not an error for a range to be empty if the second argument is omitted or in range. It's the last sentence that makes the difference here. The same behaviour is seen in csh. The patch removes a condition that appears to be deliberate. (In reply to comment #1) You have broken a documented feature! $foo[2-] or $foo[2-1] is documented to return zero words even if $foo[2] is undefined. This is important, and lots of tcsh scripts around the world depend on it continuing to work. Can you please urgently revert this change and release an update? Thanks in advance for undoing your breaking of vital tcsh functionality! Joe, have a look at https://bugzilla.redhat.com/show_bug.cgi?id=495642 they've agreed to revert the patch in 5.5, though I am personally glad someone else picked up on this. |