Bug 435541

Source http://5b4az.chronos.org.uk/pkg/hell/xfhell-1.3.tar.gz doesn't match with
the %{version} (xfhell-1.4)

unable verify sources as 1.4 is not available.

Source URL should be
http://5b4az.chronos.org.uk/pkg/hell/%{name}-%{version}.tar.gz

make changes. provides new SRPM. Will review then.

Do NOT package when tired... sorry about that.

Spec URL: http://bjensen.fedorapeople.org/pkgs/hams/SPECS/xfhell.spec
SRPM URL: http://bjensen.fedorapeople.org/pkgs/hams/SRPMS/xfhell-1.4-3.fc9.src.rpm

RPM Lint: OK
Package name: OK
Spec file: OK
License: OK (GPLv2+)
Actual License: OK (GPLv2+ from source code)
%doc License: OK (COPYING file included)
Spec file language: OK
Spec file readable: OK
Upstream source vs. used tarball: OK (md5sum match after figuring out the exact
location of the upstream tarball)
Compile and Build:
 - F-7: OK
 - F-8: OK
 - rawhide: OK
 - EL-5: OK
 - koji scratch dist-f9: OK
Applicable Package Guidelines:
 - -debuginfo package: OK (~136K)
Locales: N/A
Shared libs: N/A
Relocatable: N/A
Directory and file ownership: OK
No duplicate files in %files: OK
File Permissions: OK
Macro usage: OK
Code vs. Content: OK
(Large) Documentation: OK
%doc affecting runtime: OK
Header files in -devel package: N/A
Static Libraries in -static package: N/A
pkgconfig Requires: N/A
Library files: N/A
Devel requires base package: N/A
.la libtool archives: N/A
Duplicate ownership of files/directories: OK
Remove BuildRoot: OK
UTF-8 filenames: OK

Please adjust Source0 location to
http://5b4az.chronos.org.uk/pkg/%{name}/%{name}-%{version}.tar.gz please

New Spec URL: http://bjensen.fedorapeople.org/pkgs/hams/SPECS/xfhell.spec
New SRPM URL:
http://bjensen.fedorapeople.org/pkgs/hams/SRPMS/xfhell-1.4-4.fc8.src.rpm

Scratch built in koji for devel

URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=484636

Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=485859 
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
ecaf2a9a48478f45d56bffac35773a82  xfhell-1.4.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are honoured correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Desktop file installed correctly.
+ a GUI app.

 SHOULD:
   Ask upstream to add license file in next upstream tarball release.

APPROVED.

New Package CVS Request
=======================
Package Name: xfhell
Short Description: GTK based Ham Radio application for the Hellschreiber
communications mode
Owners: bjensen,sconklin
Branches: F-7 F-8
InitialCC: sindrepb
Cvsextras Commits: yes

cvs done.

so is this package built on all requested brnaches?
If yes can we CLOSE this review?

I requested cvs and got sidetracked, then forgot, I will build and close today.

xfhell-1.4-4.fc8 has been submitted as an update for Fedora 8

xfhell-1.4-4.fc7 has been submitted as an update for Fedora 7

Thank you for the review and reminder.

xfhell-1.4-4.fc7 has been pushed to the Fedora 7 stable repository.  If problems still persist, please make note of it in this bug report.

xfhell-1.4-4.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.